search

anthonydresser / testissues

0 stars 0 forks source link

ERR Cannot read property 'contributes' of undefined: TypeError: Cannot read property 'contributes' of undefined #97

Open adsbot[bot] opened 5 years ago

adsbot[bot] commented 5 years ago

Steps to Reproduce:

  1. Install any VSIX extension
  2. Uninstall that extension
 INFO Uninstalling the extension redgate.sql-search-0.3.1 from window 1
D:\Program Files\Azure Data Studio\resources\app\node_modules\zone.js\dist\zone-node.js:2280   ERR Cannot read property 'contributes' of undefined: TypeError: Cannot read property 'contributes' of undefined
    at file:///D:/Program Files/Azure Data Studio/resources/app/out/vs/workbench/workbench.main.js:199416:40
    at CompletePromise_ctor.CompletePromise_then [as then] (file:///D:/Program Files/Azure Data Studio/resources/app/out/vs/workbench/workbench.main.js:17896:49)
    at file:///D:/Program Files/Azure Data Studio/resources/app/out/vs/workbench/workbench.main.js:199414:50
    at Emitter.fire (file:///D:/Program Files/Azure Data Studio/resources/app/out/vs/workbench/workbench.main.js:20054:38)
    at file:///D:/Program Files/Azure Data Studio/resources/app/out/vs/workbench/workbench.main.js:20179:70
    at Emitter.fire (file:///D:/Program Files/Azure Data Studio/resources/app/out/vs/workbench/workbench.main.js:20054:38)
    at Emitter.fire (file:///D:/Program Files/Azure Data Studio/resources/app/out/vs/workbench/workbench.main.js:20057:41)
    at ChannelClient.requestEvent.arg.handlers.(anonymous function) (file:///D:/Program Files/Azure Data Studio/resources/app/out/vs/workbench/workbench.main.js:30427:70)
    at ChannelClient.onMessage (file:///D:/Program Files/Azure Data Studio/resources/app/out/vs/workbench/workbench.main.js:30497:17)
    at file:///D:/Program Files/Azure Data Studio/resources/app/out/vs/workbench/workbench.main.js:30380:89
    at Emitter.fire (file:///D:/Program Files/Azure Data Studio/resources/app/out/vs/workbench/workbench.main.js:20054:38)
    at acceptChunk (file:///D:/Program Files/Azure Data Studio/resources/app/out/vs/workbench/workbench.main.js:30828:46)
    at Socket.Protocol.Protocol.firstDataChunk._socketDataListener (file:///D:/Program Files/Azure Data Studio/resources/app/out/vs/workbench/workbench.main.js:30854:17)
    at ZoneDelegate.invokeTask (D:\Program Files\Azure Data Studio\resources\app\node_modules\zone.js\dist\zone-node.js:421:31)
    at Zone.runTask (D:\Program Files\Azure Data Studio\resources\app\node_modules\zone.js\dist\zone-node.js:188:47)
    at ZoneTask.invokeTask (D:\Program Files\Azure Data Studio\resources\app\node_modules\zone.js\dist\zone-node.js:496:34)
    at Socket.ZoneTask.ZoneTask.cancelFn.invoke (D:\Program Files\Azure Data Studio\resources\app\node_modules\zone.js\dist\zone-node.js:485:48)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at Pipe.onread (net.js:594:20)
D:\Program Files\Azure Data Studio\resources\app\node_modules\zone.js\dist\zone-node.js:2280 WARNING: Promise with no error callback:100

I noticed this while developing my first extension. Spent some hours trying to figure out what I did wrong, then realized it did this when uninstalling any extension. In the end, the extension folder is not removed. As was suggested in a Twitter response, uninstalling does not actually remove any files, by design. That makes there effectively be no difference between Disable and Uninstall, except when choosing Uninstall you must go through the steps of getting the vsix again to reinstall even though you still have the files there, that if the version hasn't changed, will simply be re-enabled, and every outdated version you still have will never be removed.

So I guess this is really 2 issues, one in the error that's shown upon uninstalling anything, and the fact that "Uninstalling" is not an accurate description of what is occurring.

adstestbot[bot] commented 5 years ago

Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: