search

anthonyec / powerlet

⚡️ Chrome Extension to quickly find and run bookmarklets
MIT License
61 stars 1 forks source link

Update deprecated `tabs.executeScript` method to new API #59

Closed anthonyec closed 1 week ago

anthonyec commented 2 years ago

https://developer.chrome.com/blog/crx-scripting-api/ https://developer.chrome.com/docs/extensions/reference/tabs/#method-executeScript

Is this review related?

Enrico B. da Luz gave you 3 stars and said: "I love the idea but most bookmarklets don't work and some just fail silently. Any suggestions? Here's an example that fails silently: javascript:alert('hi')"

anthonyec commented 2 years ago

So far I can't reproduce this, only on "protected" pages like "chrome://" URLs or the Chrome Webstore. It would be good to add a warning as part of this fix to let people know when scripts can't be executed.

anthonyec commented 1 week ago

85