search

anthonyec / powerlet

⚡️ Chrome Extension to quickly find and run bookmarklets
MIT License
61 stars 1 forks source link

Feedback / Feature Requests #61

Open ricobl opened 2 years ago

ricobl commented 2 years ago

Thanks for this lovely extension, I've been looking for something like this for a while.

Have you considered expanding the search to regular bookmarks as well? VSCode's quick open dialog searches for files by default and typing > searches for commands. Something like this would be great for keyboard navigation. Perhaps using Cmd+K for bookmarks and Cmd+Shift+K for bookmarklets.

I see that not all bookmarklets work transparently. For example: trying to use jQuery ($) from a page that has it exposed globally works when clicking from the bookmark bar but not from the extension. Is this a limitation from the extension environment?

I noticed references to a code editor in the source. Are there plans to allow editing bookmarklets as well? That would be awesome!

anthonyec commented 2 years ago

Thanks @ricobl, this is really great feedback!

Have you considered expanding the search to regular bookmarks as well?

I have thought about expanding to include Chrome functionality, like managing tabs and windows, opening specific settings etc. VSCode is a good example and it's technically straight forward to use any content in the search results. There are some questions around UX. For example, would existing users default to > at the start of their queries?

But I like the idea, and if you think showing bookmarks would be useful then it'd be a good place to start. Especially since I'm not sure if this extension can work in it's current state with the upcoming Chrome extension API changes.

I see that not all bookmarklets work transparently. For example: trying to use jQuery ($) from a page that has it exposed globally works when clicking from the bookmark bar but not from the extension. Is this a limitation from the extension environment?

Nice bug find! You're right, currently it is a limitation of how scripts are executed in Chrome. They have access to the page but live in their own separate world when it comes to accessing variables and functions. However, there are sneaky ways around this, so it's something I can look into.

I noticed references to a code editor in the source. Are there plans to allow editing bookmarklets as well? That would be awesome!

Yep, it's something I've been playing around with for ages! However, it's a very nuanced problem to format a bookmarklet for editing, and then convert back (my attempt so far). Not impossible, just requires a lot of testing to ensure I don't break everyones scripts. That fear has been keeping me from releasing something I'm happy with.

anthonyec commented 1 week ago

@ricobl not sure if you still use this extension. But just to let you know, a big part of Powerlet was rewritten recently to support some Chrome changes. And as a result, the jQuery issue should be fixed now!

ricobl commented 1 week ago

Hey @anthonyec! Yeah, I'm still using it, I gave using globals like jQuery a try and it seems to be working indeed, great job migrating to the manifest v3. Thanks for getting back to me!