search

anthonygore / vue-router-user-roles

A Vue.js plugin that protects routes based on user roles. Add your own authentication.
MIT License
241 stars 27 forks source link

Protected content appears before role validation is complete #8

Open sbay opened 5 years ago

sbay commented 5 years ago

vue & vue-router-permissions version

Vue -- 2.5.21 Vue Router -- 3.0.2

Reproduction Link

Out of the box

Steps to reproduce

Setup access per documentation. Notice how when you have a protected route, it will flash before redirecting when access is not allowed.

What is Expected?

Protected content will not be shown during access validation. Should most likely tie into VueRouter's navigation guards logic (ie beforeEach) to bring validation higher up the chain.

What is actually happening?

Protected content is appearing on screen before access validation is performed and executed.

anthonygore commented 5 years ago

Thanks for reporting, I'll look into it

anthonygore commented 5 years ago

Do you have a reproduction link? The thing is, this runs synchronously and is triggered by the Vue Router beforeEach hook, which, by definition, will run before the route is accessed. I think we have to rule out the possibility of there being a different error in your scenario.