anthonyjgrove / react-google-login

A React Google Login Component
https://anthonyjgrove.github.io/react-google-login
MIT License
1.84k stars 427 forks source link

Missing props in GoogleLogoutProps TypeScript #467

Open rteshnizi opened 3 years ago

rteshnizi commented 3 years ago

The provided type for the GoogleLogoutProps is missing many of the props listed in the documentation. I noticed it when I was trying to set theme.

This is what is in index.d.ts

export interface GoogleLogoutProps {
  readonly clientId: string,
  readonly onLogoutSuccess?: () => void;
  readonly onFailure?: () => void;
  readonly buttonText?: string;
  readonly className?: string;
  readonly children?: ReactNode;
  readonly jsSrc?: string;
  readonly style?: CSSProperties;
  readonly icon?: boolean,
  readonly disabled?: boolean;
  readonly disabledStyle?: CSSProperties;
  readonly tag?: string;
  readonly render?: (props: { onClick: () => void, disabled?: boolean }) => JSX.Element;
}

I have react-google-login@5.2.2

thefenry commented 2 years ago

Any update on this? Seems like I am having the same issue