anthonyjgrove / react-instagram-login

A React Component for Instagram Login
MIT License
64 stars 25 forks source link

Let's revive this module #13

Open alexandrtovmach opened 4 years ago

alexandrtovmach commented 4 years ago

Development is staled, API deprecated... sad to see that. I'd be happy to implement a new module, but you already used react-instagram-login name on NPM and I can't do that. Let's discuss ways to revive this module.

I had an experience in implementing modules like this: https://github.com/alexandrtovmach/react-microsoft-login https://github.com/crowdin/react-crowdin-login

alexandrtovmach commented 4 years ago

@anthonyjgrove Please let us know what you think

anthonyjgrove commented 4 years ago

@alexandrtovmach sounds good, do you want to just create a PR of the updates you think are needed, we can add automated deployment and testing that I have been working on for react-google-login. Let me know if you have any other thoughts.

alexandrtovmach commented 4 years ago

I think we can go through next steps for now:

  1. update module according to API updates
  2. configure CI/CD to make releases automatically
  3. implement demo page
alexandrtovmach commented 4 years ago

What you think about using TS? By migrating to TS we can solve https://github.com/anthonyjgrove/react-instagram-login/issues/8 ?

alexandrtovmach commented 4 years ago

@anthonyjgrove ping

anthonyjgrove commented 4 years ago

Busy week at work, will take a look this weekend 👌

anthonyjgrove commented 4 years ago

@alexandrtovmach yes 100% down for adding typescript.

alexandrtovmach commented 4 years ago

@anthonyjgrove Hello, I tried to update your package, but for me it was easier to write everything from scratch (actually I used my previous packages as boilerplate). Here is result: https://alexandrtovmach.github.io/react-instagram-login/

What do you think about making my solution as "v2" of this package? On other hand I can publish it as alternative, but I really want to save namespace react-productname-login, and your package is already used it.

let me know what you think

anthonyjgrove commented 4 years ago

Just took a quick look it is mostly good, the main concern i have right now is it looks like you have your "app_secret" on the client which is not something you want to do and would not want users of the button doing.

alexandrtovmach commented 4 years ago

@anthonyjgrove That's not a sensitive data, because this key is development only, and can't be used by anyone except my whitelisted accounts.

alexandrtovmach commented 4 years ago

So what is the next step?

bobber205 commented 4 years ago

@alexandrtovmach It IS sensitive data -- to use the package on production (which is why you'd want the name is to make this the official package for implementing the new Instagram login) you don't wanna expose that to everyone. Surely the react-platform-login should not have a glaring security flaw right?