Open alexandrtovmach opened 4 years ago
@anthonyjgrove Please let us know what you think
@alexandrtovmach sounds good, do you want to just create a PR of the updates you think are needed, we can add automated deployment and testing that I have been working on for react-google-login. Let me know if you have any other thoughts.
I think we can go through next steps for now:
What you think about using TS? By migrating to TS we can solve https://github.com/anthonyjgrove/react-instagram-login/issues/8 ?
@anthonyjgrove ping
Busy week at work, will take a look this weekend 👌
@alexandrtovmach yes 100% down for adding typescript.
@anthonyjgrove Hello, I tried to update your package, but for me it was easier to write everything from scratch (actually I used my previous packages as boilerplate). Here is result: https://alexandrtovmach.github.io/react-instagram-login/
What do you think about making my solution as "v2" of this package? On other hand I can publish it as alternative, but I really want to save namespace react-productname-login
, and your package is already used it.
let me know what you think
Just took a quick look it is mostly good, the main concern i have right now is it looks like you have your "app_secret" on the client which is not something you want to do and would not want users of the button doing.
@anthonyjgrove That's not a sensitive data, because this key is development only, and can't be used by anyone except my whitelisted accounts.
So what is the next step?
@alexandrtovmach It IS sensitive data -- to use the package on production (which is why you'd want the name is to make this the official package for implementing the new Instagram login) you don't wanna expose that to everyone. Surely the react-platform-login should not have a glaring security flaw right?
Development is staled, API deprecated... sad to see that. I'd be happy to implement a new module, but you already used
react-instagram-login
name on NPM and I can't do that. Let's discuss ways to revive this module.I had an experience in implementing modules like this: https://github.com/alexandrtovmach/react-microsoft-login https://github.com/crowdin/react-crowdin-login