search

anthonykirby / lora-packet

LoRa radio packet decoder
MIT License
261 stars 83 forks source link

FOpts start at 7 not 6 #3

Closed davidonet closed 7 years ago

davidonet commented 8 years ago

According to spec : 0..4 : devAddr 4..5 : FCtrl 5..7 : FCnt 7.. : FOPts

anthonykirby commented 7 years ago

Hi David, thank you for the fix; I'm planning to merge this, but you've made it much harder for me to review by making whitespace/formatting changes to 500 other lines. I'll try to do it next week. Anthony

davidonet commented 7 years ago

Sorry, my editor format on save. You can ignore this pull request and make the correction on line 150 in packet.js p.FOpts = p.MACPayload.slice(6, 6 + FOptsLen); become p.FOpts = p.MACPayload.slice(7, 7 + FOptsLen); I'll resynchronise with your original formatting for further addon. Thanx for sharing your work.

anthonykirby commented 7 years ago

having written a test this also flushed out another bug - thank you!