search

anthonykulis / automobile

CPS206 In-Class Project Repository (WIP)
2 stars 12 forks source link

`Graphic` class needs to be rewritten #17

Open anthonykulis opened 7 years ago

anthonykulis commented 7 years ago

https://github.com/anthonykulis/automobile/blob/master/edu/jalc/automobile/parts/Graphic.java#L1

2 points

anthonykulis commented 7 years ago

i think this can simply have the attribute of graphic (which is same as class name), refactored to something like name

KenanJones commented 7 years ago

I have added a constructor to Graphic in my repo that takes a String parameter. since it overloads the constructor, it shouldn't mess anyone else up.

anthonykulis commented 7 years ago

No. If you are going to handle issues existing on automobile, you need to make a separate fork and pr for that issue. If you commit what is in your repo, you will break everyone elses.

On Wed, Apr 19, 2017 at 11:58 AM, KenanJones notifications@github.com wrote:

I have added a constructor to Graphic in my repo that takes a String parameter. since it overloads the constructor, it shouldn't mess anyone else up.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/anthonykulis/automobile/issues/17#issuecomment-295344745, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-8Me--IH1TsY-UdUdS9toG9UYdSp06ks5rxj08gaJpZM4MpGlB .

KenanJones commented 7 years ago

it is included in the pr I just made