search

anthonykulis / automobile

CPS206 In-Class Project Repository (WIP)
2 stars 12 forks source link

CoupeBody is not public #85

Closed KenanJones closed 7 years ago

KenanJones commented 7 years ago

@anthonykulis CoupeBody is not public, so I couldn't use it. I have changed it to public on my repo, but the other car team will need it too. looks like all the other classes extending body are public.

anthonykulis commented 7 years ago

Stop changing things on your public repo. seriously. If there is an issue on the core source, fork the repo into a new one, fix the issue, and make a pr. if you change the core in your repo, 10 other people will not have the source. if everyone did that, everything is broken. tag me when you create the new pr. i will give +1 ec on this.

On Wed, Apr 19, 2017 at 12:02 PM, KenanJones notifications@github.com wrote:

@anthonykulis https://github.com/anthonykulis CoupeBody is not public, so I couldn't use it. I have changed it to public on my repo, but the other car team will need it too. looks like all the other classes extending body are public.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/anthonykulis/automobile/issues/85, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-8MWl8z9KgB90zvW2PhDWHsZfD9gUqks5rxj4jgaJpZM4NB97V .

KenanJones commented 7 years ago

@anthonykulis I also fixed some smaller errors I found. I have made the pr.

anthonykulis commented 7 years ago

thanks

On Wed, Apr 19, 2017 at 2:10 PM, KenanJones notifications@github.com wrote:

@anthonykulis https://github.com/anthonykulis I also fixed some smaller errors I found. I have made the pr.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/anthonykulis/automobile/issues/85#issuecomment-295396408, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-8MXZiIuMzJV8t01CB7qMDrn2QF8agks5rxlxCgaJpZM4NB97V .

anthonykulis commented 7 years ago

done.