search

anthonykulis / automobile

CPS206 In-Class Project Repository (WIP)
2 stars 12 forks source link

CrewCab issue #91

Open nourelhoda89 opened 7 years ago

nourelhoda89 commented 7 years ago

@anthonykulis Can you please make CrewCab in package edu.jalc.automobile.onlinebuilder.components.body.truck; accept Cabin instead of luxuryCabin (line 12 and 13), I tried several other cab but all take certain types of cabins and seats which would not work for us.

anthonykulis commented 7 years ago

No. Just go ahead and make luxury cabins for crew cabs. They technically are anyways. On Fri, Apr 21, 2017 at 11:16 AM نور الهدى notifications@github.com wrote:

@anthonykulis https://github.com/anthonykulis Can you please make CrewCab in package edu.jalc.automobile.onlinebuilder.components.body.truck; accept Cabin instead of luxuryCabin (line 12 and 13), I tried several other cab but all take certain types of cabins and seats which would not work for us.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/anthonykulis/automobile/issues/91, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-8MWbU4f2eneLkQHczW67PgTckz-Qeks5ryNZAgaJpZM4NEgTU .

nourelhoda89 commented 7 years ago

Sorry I just read your reply! For a starter luxuryCabin only take leatherSeat, and StandardCabin only take ClothSeat. so if I use StandardCab which only take Standard Cabin I am limited to ClothSeat, if I us ExtendedCab which only take luxuryCabin i am limited to LeatherSeat and CrewCab as it is will limit seat to Leather as well. for choosing a Seat to work in the builder I had to make all of them extends TruckSeat, which extends Seat, not any specific types of seat. So we are stuck to either change CrewCab to take all types of Cabin, not just Luxury, or use StandardCab but change StandardCabin to accept Seat not just ClothSeats. Either one should not hurt any ones code since its giving more options not limiting them. What do you think??