anthonylangsworth / FCMS

An EDMC plug-in that updates https://fleetcarrier.space with fleet carrier movements in the game Elite: Dangerous.
GNU General Public License v3.0
8 stars 0 forks source link

fcms plugin using player location instead of carrier location when posting jump into discord #5

Closed LexRottie closed 2 years ago

LexRottie commented 2 years ago

As the title says the plugin seams to be using the player location instead of the carrier location in the departing section of the discord post

anthonylangsworth commented 2 years ago

Thanks for raising the issue. Unfortunately, this is a known issue, as per the README.

The problem is the https://fleetcarrier.space API the plug-in calls requires the current location of the carrier. Unfortunately, neither the Elite: Dangerous client nor EDMC know the location of your carrier. Therefore, the best guess is the current system your commander is in. EDMC and the Elite: Dangerous journal file both provide this. See https://github.com/FuelRats/FCMS/blob/master/FCMS/views/api.py if you can read Python and are interested in the internals.

I apologise that we cannot do any better.

LexRottie commented 2 years ago

No probs hopefully they will add that info for it to pull

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: Anthony @.> Sent: 01 November 2021 13:04 To: @.> Cc: @.>; @.> Subject: Re: [anthonylangsworth/FCMS] fcms plugin using player location instead of carrier location when posting jump into discord (Issue #5)

Thanks for raising the issue. Unfortunately, this is a known issue, as per the README.

The problem is the https://fleetcarrier.spacehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ffleetcarrier.space%2F&data=04%7C01%7C%7Cb34e8cd6e8c243d91f0608d99d381de8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637713686607420516%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=qtgGxHUWKuXXBDXqN57BsdKOg5EpdxBBlgzdJHNe%2BDI%3D&reserved=0 API the plug-in calls requires the current location of the carrier. Unfortunately, neither the Elite: Dangerous client nor EDMC know the location of your carrier. Therefore, the best guess is the current system your commander is in. EDMC and the Elite: Dangerous journal file both provide this. See https://github.com/FuelRats/FCMS/blob/master/FCMS/views/api.pyhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FFuelRats%2FFCMS%2Fblob%2Fmaster%2FFCMS%2Fviews%2Fapi.py&data=04%7C01%7C%7Cb34e8cd6e8c243d91f0608d99d381de8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637713686607420516%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=0fnr85lGe%2FJpvrF9mOjo14vvjqNMo8jO065kLJM1tm0%3D&reserved=0 if you can read Python and are interested in the internals.

I apologise that we cannot do any better.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fanthonylangsworth%2FFCMS%2Fissues%2F5%23issuecomment-956214710&data=04%7C01%7C%7Cb34e8cd6e8c243d91f0608d99d381de8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637713686607430473%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=UdLoGF78Sr%2F3HMfZk%2BO85OFHo%2FIBr3eaPrB7abi2vPs%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUIBGEWFHZF3BSA3OTTYWLTUJ2F5FANCNFSM5HCKV5JA&data=04%7C01%7C%7Cb34e8cd6e8c243d91f0608d99d381de8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637713686607430473%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=wTjdK2snZNwMLkZOSBJBn%2FjxZjslp2rIejpDjMTXNNg%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Cb34e8cd6e8c243d91f0608d99d381de8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637713686607440429%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Zap9pnoWUdr1QD8bcGY5s7bfj3R6Rr1rSAnXcSgGvc8%3D&reserved=0 or Androidhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7Cb34e8cd6e8c243d91f0608d99d381de8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637713686607440429%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=YBVjoscwytUfIpBdyCDG44tU0czC0g4UXU4MsBMnonk%3D&reserved=0.

anthonylangsworth commented 2 years ago

Thanks for your understanding.