Instructor Feedback - Week 15

[pawaitemadisoncollege]

Beth identified lots of good items in her review. Here are a few more (apologies if I duplicated any of hers)

• [ ] Lombok is listed as one of your technologies - if you choose not to implement it, remember to remove it from your readme.md
• [ ] Refactor long methods such as https://github.com/anthonymp13/InvoiceGenerator/blob/519da5b494517d3413ab37470bc357eb9e6788f4/src/main/java/anthony/com/controller/GenerateInvoice.java#L58-L126
• [ ] Some hard-coded values may be better place in a properties file for easy updating. Example: https://github.com/anthonymp13/InvoiceGenerator/blob/519da5b494517d3413ab37470bc357eb9e6788f4/src/main/java/anthony/com/generator/PdfInvoicesBasic.java#L54-L63 Do those paths work on aws?
• [ ] Unit testing of the pdf generation?

[pawaitemadisoncollege]

One more: Is everything locked down here that should be? https://github.com/anthonymp13/InvoiceGenerator/blob/04f6d125999630a4d2646b6b669b1736dc8f7f7c/src/main/webapp/WEB-INF/web.xml#L21-L41

[pawaitemadisoncollege]

And... one more! Custom error pages would be a nice touch if you have time - doesn't have to be fancy, just something improved over the default error pages.