Feedback: Switching themes works out of the box

anthonynorth / rscodeio

An RStudio theme inspired by Visual Studio Code.

Other

407 stars 65 forks source link

Feedback: Switching themes works out of the box #18

Closed jmbuhr closed 3 years ago

jmbuhr commented 5 years ago

Just wanted to let you know that switching themes works for me out of the box, even with changing menu-elements. That's really cool so, I will investigate, why I don't need the rscodeio::deactivate_menu_theme functions.

I am switching between themes via rstudioapi::applyTheme("rscodeio"), which I packaged up as an addin: link to repo.

Thank you for this amazing theme!

anthonynorth commented 5 years ago

Once installed, the menu theme is applied when any dark editor theme is applied; rscodeio::deactivate_menu_theme will revert the menu theme back to the default dark menu theme for dark editor themes. https://github.com/rstudio/rstudio/blob/master/src/cpp/desktop/DesktopUtils.cpp#L131

jmbuhr commented 5 years ago

Right, now I get it! Thanks :)

salim-b commented 3 years ago

@anthonynorth I think this issue can be safely closed.