search

anthonynorth / rscodeio

An RStudio theme inspired by Visual Studio Code.
Other
407 stars 65 forks source link

Fira code #32

Closed mkarmstrong closed 3 years ago

mkarmstrong commented 4 years ago

I use font Fira code https://github.com/tonsky/FiraCode in rstudio but it is not implement correctly when using rscodeio theme. The font is applied correctly to text but not to special characters. Any intuition as to why this might be? Fantastic theme! Many thanks, Matt

mkarmstrong commented 4 years ago

Got it, if anyone was interested, find the code shown below in the theme file and change off to on:

.rstudio-themes-flat .ace_editor_theme { background-color: var(--editor-background); color: var(--editor-foreground); font-feature-settings: "liga" off, "calt" off; line-height: 1.3 !important; }

anthonynorth commented 4 years ago

This was a bug I fixed a while ago (c3ad6dd). Re-install the package and the theme to apply the fix.

salim-b commented 3 years ago

@anthonynorth I think this issue can be safely closed.