anthonynorth / rscodeio

An RStudio theme inspired by Visual Studio Code.
Other
409 stars 66 forks source link

Incorrect menu bar colour on RStudio Preview 1.3.776 #35

Open dwhdai opened 4 years ago

dwhdai commented 4 years ago

I just updated to the newest RStudio Preview release and noticed the menu bar colour is not inconsistent with the rest of the theme. Is there a fix for this?

image

If someone can point me in the direction, I'd be happy to take a look :)

luciorq commented 4 years ago

Hello,

Can you elaborate on the Operational System and Version you are running on? Different OS's install the theme files in a different folder. E.g. Ubuntu Linux install at path /usr/lib/rstudio/resources/stylesheets/

You will have to find the path of installation and find resources/stylesheets/ and you will see some .QSS files inside it, those are the theme files.

This is where the rscodeio package install the modified files when you execute: rscodeio::install_theme() and rscodeio::activate_menu_theme()

the files that the package uses are inside the folder (https://github.com/anthonynorth/rscodeio/tree/master/inst/resources/stylesheets)

This one is for Linux: Link

This one is for Windows: Link

I hope to shed some light!

luciorq commented 4 years ago

I have created an Issue (#37 ) to track the changes in the 1.3 update in multiple OS's, remember that 1.3 is a preview build and can change some styles before proper release.

The issue #37

salim-b commented 4 years ago

I just updated to the newest RStudio Preview release and noticed the menu bar colour is not inconsistent with the rest of the theme.

This has nothing to do with the particular RStudio version. The QSS file styling the menu bar gets overwritten everytime RStudio is updated/reinstalled.

You have to run rscodeio::activate_menu_theme() (or rscodeio::install_theme() which calls the former function) as administrator again in order the get the rscodeio menu bar again. There is nothing we can do about this since styling QSS files is not supported by RStudio's current theming API.

@anthonynorth I think this issue can be closed.