salim-b
commented
3 years ago @anthonynorth Did you have a chance to look at this PR?
Open salim-b opened 3 years ago
salim-b
commented
3 years ago @anthonynorth Did you have a chance to look at this PR?
rewrite majority of R code to be more consistent and logically coherent incl. lots of renamings; use consistent style (mostly tidyverse-compliant; but line width @ 160)
improve QSS installation for Windows by checking file access permissions; display a warning with more infos if permissions are insufficient (not admin)
improve QSS installation for Linux: ask interactively for administrator credentials by calling Polkit's
pkexecand perform all admin-level actions in one goimprove/extend documentation; should be less confusing now for users who haven't heard about RStudio's QSS files before
improve/extend package title and description
update and convert README to R Markdown format (and generate
README.mdusingdevtools::build_readme()) to make use of RStudio 1.4's new Markdown canonicalizationneeds testing on Windows! otherwise package should be more-or-less ready for a CRAN submission at this point (though we might want to tackle other issues first)