anthonynosek / sprint-reader-chrome

A speed reading Google Chrome extension (via Rapid Serial Visual Presentation).
Other
216 stars 54 forks source link

Google threatening to remove from store for not following "best practices"? #42

Open JamesNewton opened 1 month ago

JamesNewton commented 1 month ago

In the store, I'm seeing a message that this extension may be removed because of some best practice issue.

Anyone know what the issue is?

Is there a way I can help to make sure it remains available? I honestly depend on it.

JamesNewton commented 1 month ago

"This extension may soon no longer be supported because it doesn't follow best practices for Chrome extensions." https://chromewebstore.google.com/detail/sprint-reader-speed-readi/kejhpkmainjkpiablnfdppneidnkhdif

anthonynosek commented 1 month ago

Thanks for posting this issue.

Sprint Reader is largely undeveloped at this point in time due to other commitments however I would like to know that it can still be downloaded and installed from the Google Store. I can see that many people are still actively using the extension.

When I can, I will investigate and in the meantime- should anyone wish to add to this or provide information on what we need to do in order to resolve the issue regarding best practice- please add to this issue.

JamesNewton commented 1 month ago

I'm very happy that you are willing to keep it going. If I'm able, I will attempt to contribute.

Strangely, I just checked again and the message is gone!

The only thing I do see is "The developer has not provided any information about the collection or usage of your data."

anthonynosek commented 1 month ago

After a little investigation the solution is to migrate the extension to support the latest manifest version (version 3). The changes are not trivial to upgrade and support the new manifest so I will have to add this to a to-do list.

If anyone would like to tackle the migration to manifest version 3 it may expedite the resolution.

JamesNewton commented 1 month ago

It looks like the most difficult part is this? https://developer.chrome.com/docs/extensions/develop/migrate/to-service-workers#changes_youll_need_to_make (just to be very clear, I do NOT think I can help with this, except in very small / mindless ways. This type of code is not where I have experience.

anthonynosek commented 2 weeks ago

@JamesNewton Just an FYI, I have not forgotten you. I have spent time rewriting Sprint Reader to support Chrome Extensions Manifest v3 and I am 95% complete. I am working on it in the background with other tasks such as life, small kids etc :-)

Rest assured, my goal is to release soon (possibly to closed testing which will include yourself) and also to support Firefox.

All in good time- I am getting there.... slowly.

anthonynosek commented 1 week ago

@JamesNewton Have submitted version 3.0 to Google for review. Of course, I have tested the extension, could you do a review for me once I publish it also?

JamesNewton commented 1 week ago

I thought I saw it update, but it's still on 2.5 in my browser. Anything I need to do to update it? Just wait for the release?

anthonynosek commented 6 days ago

You may have auto-updates disabled in Chrome. Just venture to “Manage Extensions” and force the update manually. I have tested the release path and the production extension updates with no issue.

Let me know if you continue to have problems.

On 22 Sep 2024, at 04:27, JamesNewton @.***> wrote:

I thought I saw it update, but it's still on 2.5 in my browser. Anything I need to do to update it? Just wait for the release?

— Reply to this email directly, view it on GitHub https://github.com/anthonynosek/sprint-reader-chrome/issues/42#issuecomment-2365278673, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDBLHANEQAPO52USKFB243ZXW3A3AVCNFSM6AAAAABMKCEPFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGI3TQNRXGM. You are receiving this because you commented.

JamesNewton commented 5 days ago

I don't see a way to force the update... I do see an "Update" button on the Manage Extensions section and when I press it, nothing happens. My installed version is 2.5 and the version I see in the chrome web store is 3.0.

I can uninstall it and reinstall it, but I wonder if there is a way to debug the fact that it's not updating on this PC? It's Ubuntu, and Chrome is up to date.

anthonynosek commented 21 hours ago

@JamesNewton I am not able to test Chrome on Ubuntu, my comments were for Chrome on Mac however I was assuming the update process is the same across Windows, Mac and Linux.

I shall investigate this when I have the time- will try and fire up a Linux VM to test. For the meantime, I suggest you uninstall and install the latest version directly from the store.

JamesNewton commented 10 hours ago

Well... poop! I uninstalled 2.5 and when I try to install 3.0 from the store, I get an "Invalid manifest" error. The console.log just says "Unchecked runtime.lastError: Invalid manifest"

So now I can't use the extension at all! Sad face.

I don't see any other debug info... Looking at the manifest, the only thing I notice is that there is no linux option for the hotkey, but I doubt that would cause the install to fail: https://github.com/anthonynosek/sprint-reader-chrome/blob/master/manifest.json#L36

Having said that, it looks like other HAVE seen failures for this reason. The trick seems to be that it needs a default option? https://groups.google.com/a/chromium.org/g/chromium-extensions/c/QqN2H2mVMuQ?pli=1