search

anthonynsimon / bild

Image processing algorithms in pure Go
MIT License
4.02k stars 214 forks source link

[Feature]Perlin noise #73

Closed roz3x closed 5 years ago

roz3x commented 5 years ago

I have added few files in my local repo , that enables noise package to give images with coherent noise .Yes , using parallel implementation , like as of other noise functions . I wanted to know about

  1. should i commit directly to master branch .
  2. is it necessary to write tests for noise functions
anthonynsimon commented 5 years ago

Hey, thanks for your interest in contributing.

  1. You should create a GitHub PR first to have your work merged into the repo.

  2. Yes, it’s ok to not write a test in this case.

Looking forward to your PR!

On Thu 5. Sep 2019 at 20:27, roz3x notifications@github.com wrote:

I have added few files in my local repo , that enables noise package to give images with coherent noise .Yes , using parallel implementation , like as of other noise functions . I wanted to know about

  1. should i commit directly to master branch .
  2. is it necessary to write tests for noise functions

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/anthonynsimon/bild/issues/73?email_source=notifications&email_token=ADFDEB5P5QLE73W5BL2BH6TQIFFSZA5CNFSM4IUBBYA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HJTWTAQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFDEB3V6LUO3NXLCSK7ZN3QIFFSZANCNFSM4IUBBYAQ .

roz3x commented 5 years ago

hey ! thanks for responding . here is the link to my repo .(https://github.com/roz3x/bild) .. please let me know , if this follows your projects guidelines .. <3

roz3x commented 5 years ago

i also added a code snippet to readme.md file and the working example is in main.go file

roz3x commented 5 years ago

hey thanks , would you like to merge the pr , with the master ?? please tell me before or if you do so .

regards

anthonynsimon commented 5 years ago

Hey, I added a review on the PR #74