Bug: Dashing in ordinal directions on corners and uneven geometry can lock the player in the dash state

Wolfcl0ck commented 6 months ago

Bug Description

If the player dashes in an ordinal direction (45 degree angle, holding two directional keys on keyboard) into either a corner that they can then push themselves around during the dash or into uneven geometry (such as props on the floor or uneven terrain,) the player can become locked in the dash state, or continue dashing for longer than expected, leading to the player becoming unable to control Maria. This bug has also happened in cardinal directions at times in the past on props, but I wasn't able to recreate this.

Reproduction Steps

enter into a level
holding two directional keys, dash either into a corner in such a way that the dash will cause you to move around the corner, or into a static prop on the ground that causes the ground to become uneven.
If done correctly, the player will either become stuck in a dash until they hit a wall, or will continue to dash for longer than expected.

Bug Frequency

Common and Consistent

Bug Importance

Somewhat important, bug can hinder gameplay sometimes

Platform

Windows

Desktop or Laptop?

Desktop

If Laptop, was your laptop plugged in?

None

Editor or Build?

Both

If Build, What Build?

March 1st Build, but has been present for a while

If Editor, What Branch?

Main

If Editor, Most Recent Push

c8c54f3

If Editor, Menu or Direct Load?

Both

Every Time or First Load?

Every Time

Was the computer under heavy load?

Computer was NOT under heavy load

Anything else?

The likely best solution, in my opinion, would be to force the player to revert to regular movement once the dash time is complete via a coroutine. Here's the footage I got from several different locations on several different levels:

https://github.com/anthonypollos/2023-Game-Design-Masters/assets/16748747/067ef46c-9df0-47f9-9c11-2c3c60fde833

https://github.com/anthonypollos/2023-Game-Design-Masters/assets/16748747/7eedf873-119a-462c-8469-ecae1d1d970b

https://github.com/anthonypollos/2023-Game-Design-Masters/assets/16748747/b7f2656d-ac66-4eb2-9966-79532a024d5b

https://github.com/anthonypollos/2023-Game-Design-Masters/assets/16748747/76968448-a033-4d32-937d-3e3a59bda9c1

https://github.com/anthonypollos/2023-Game-Design-Masters/assets/16748747/a53e1f79-adcc-437e-b2d0-d5f7a0a6940f

https://github.com/anthonypollos/2023-Game-Design-Masters/assets/16748747/3db35f4d-7111-4511-a9b7-f734bdc04b9b