anthonyraymond / joal

An open source command line RatioMaster with an optional WebUI.
Apache License 2.0
613 stars 65 forks source link

Error for all authkey tracker #171

Open bingyu50 opened 2 years ago

bingyu50 commented 2 years ago

got below error for this kind of tracker: https://aaa.bbb.cccc/announce.php?authkey=9207|885|AJ2uIk80]

"TORRENT WAS REJECTED BY SERVER: JAVA.NET.URISYNTAXEXCEPTION: ILLEGAL CHARACTER IN QUERY AT INDEX 48: https://aaa.bbb.cccc/announce.php?authkey=9207|885|AJ2uIk80]"

bingyu50 commented 2 years ago
image
laur89 commented 2 years ago

@anthonyraymond is this likely thrown from com.turn.ttorrent.common.Torrent, possibly line #176 (URI uri = new URI(tracker.getString());)? Sounds like they should encode the uri before feeding it to URI constructor.

hinevergo commented 2 years ago

@anthonyraymond is this likely thrown from com.turn.ttorrent.common.Torrent, possibly line #176 (URI uri = new URI(tracker.getString());)? Sounds like they should encode the uri before feeding it to URI constructor.

Is there any pull requests? Thank you very much !

laur89 commented 2 years ago

No PRs. What needs be done: a) verify it's solved in turn.ttorrent project's upstream; if not, fix it there first; b) upgrade joal to use latest version of ttorrent (currently used version is quite a bit behind)

I might take it on, but only if/when #172 is merged.

cwyalpha commented 1 year ago

Caused by: java.net.URISyntaxException: Illegal character in query at index 53: https://xxx/announce.php?authkey=12345|67890|abcxyz at java.base/java.net.URI$Parser.fail(URI.java:2973) at java.base/java.net.URI$Parser.checkChars(URI.java:3144) at java.base/java.net.URI$Parser.parseHierarchical(URI.java:3232) at java.base/java.net.URI$Parser.parse(URI.java:3174) at java.base/java.net.URI.(URI.java:623) at com.turn.ttorrent.common.Torrent.(Torrent.java:191) ... 8 more

I have the same issue, but an earlier version of joal is OK for this site

anthonyraymond commented 1 year ago

Hello there, i'm aware of this issue, but i'm having a lot of work atm and i don't have much time to look at it to eventually fix the issue on my spare time.

But i will as soon as possible. I'll keep you updated

HmgvPy4Q commented 1 year ago

Temporary solution: encode '|' to '%7C' (edit the tracker url in the torrent file).

anthonyraymond commented 1 year ago

Note to me: Should be possible to update to latest version of ttorent and replace parsing with : com/turn/ttorrent/common/TorrentParser.java

Joal is using an old version, but i don't think that it'm depending of ttorrent too much except for some constants or parsing.

Maybe @laur89 will happen to have some time before i do ^^.

Place your bets.

butts136 commented 1 year ago

Hi, Any news about this problem ? Editing ('|' to '%7C') the trackers is not that easy when you download a couple torrents a day.

Just asking, Thanks ;)

laur89 commented 1 year ago

@butts136 been away from joal for a while. Will try to make some time coming week, but no promises.

skywalkerscott commented 1 year ago

@butts136 been away from joal for a while. Will try to make some time coming week, but no promises.

Are there any other tools similar to JOAL? The authkey problem is still there.