anthonyraymond / joal

An open source command line RatioMaster with an optional WebUI.
Apache License 2.0
576 stars 63 forks source link

partial leecher warning #178

Open joihn opened 1 year ago

joihn commented 1 year ago

thanks for this cool repo, note: the auto-weighting equation for upload bandwidth repartition is smart, but unfortunately does not take into account partial leecher (people who partially downladed the torrent and ignored some files in their client (frequent in torrent pack), thus they are acually seeder but reported as leecher), which could lead to a massive upload on a small torrent full of only partial leechers, thus leading to a tracker detection and a ban.

For the next version written in Go, I would humbly suggest a per torrent speed selector, which would allow setting those to 0 for upload speed (while keeping them for H&R avoidance).

anthonyraymond commented 1 year ago

I understand your point, but this is a difficult problem to solve, i'll keep it opened as a possible improvement. But it's unlikely to be implemented any time soon.

bobarbobo commented 1 year ago

https://github.com/lkjasdfoi/myjoal/commit/473c5e90d49d17c2436ba9ad6269b06c2d38170a with this (naive) implementation, torrent whose filename starts with "HR" will get a weight of 0, thus a speed of 0. :)

anthonyraymond commented 1 year ago

Well, it's probably working but it don't quite like the way it works.