search

anthonyreilly / NetCoreForce

Salesforce REST API toolkit for .NET Standard and .NET Core
MIT License
111 stars 63 forks source link

ForceClient.TestConnection() not implemented #6

Closed charliefoxtwo closed 5 years ago

charliefoxtwo commented 5 years ago

Today we found out the hard way that the TestConnection() method is not yet implemented. Are there any plans to either implement this, document that the method is not implemented, or potentially add an ObsoleteAttribute to warn developers not to use this method? We had it alongside a null-coalescing operator, so we didn't notice until the one time our ForceClient object wasn't actually null.

ForceClient.cs lines 69-72:

public bool TestConnection()
{
    throw new NotImplementedException();
}
anthonyreilly commented 5 years ago

Sorry about that, I'll get that implemented and published in the next couple days.

charliefoxtwo commented 5 years ago

This is excellent, thank you!

anthonyreilly commented 5 years ago

Fix in v2.5.0, published to Nuget