search

anthonyrisinger / mkinitcpio-btrfs

This hook provides advanced support for single and multi device btrfs partitions, including rollback operations at boot time.
https://aur.archlinux.org/packages/mkinitcpio-btrfs
21 stars 7 forks source link

some features i worked on #1

Closed visit1985 closed 11 years ago

visit1985 commented 11 years ago

Hi @xtfxme

First of all: Thanks for this awesome script! I played with it for some weeks now and wanna share my outcome. Please don't be scared, I've rewritten a pretty huge part of the script to use btrfs subvolume set-default to mark the subvolume to boot. I also tried to implement all your FIXME's.

I would appreciate it, if you find some time to have a look on it and tell me your thoughts.

Thanks, @visit1985

anthonyrisinger commented 11 years ago

awesome! 95% of this LGTM, with only a couple minor changes i will detail ASAP... i just got married last weekend, and moved to a new home just 2 days ago, so i'm a wee bit busy ATM, but i should be able to give you real feedback before next week.

visit1985 commented 11 years ago

My sincere congrats! No need to rush. I'm in vacation until Sept. 19th and probably offline until then. Take care on your wife instead. That's more important ;)

visit1985 commented 11 years ago

Can you please detail the "minor changes" you mentioned? I'm planing to implement auto-mounting of degraded raid volumes, which is the only major feature missing, I think. While doing that, I can take care of these fixes, to get this up to the AUR asap.

anthonyrisinger commented 11 years ago

they are not important enough to worry about... merged; btw, if you'll be working on more issues/features, i don't have a problem adding you to the repository so you can commit and/or handle pull reqs without me. when life stops eating my time i'll be more in the game, but that time is not now.

anthonyrisinger commented 11 years ago

i don't like setting the default subvolume much, because in the past it's been flaky and i think the mount option is safer/clearer, but we'll try it out

triplem commented 11 years ago

I agree with xtfxme. I do find it more KISS to declare the subvolume directly in the fstab.

visit1985 commented 11 years ago

@xtfxme: I found it more simple and clear for the non-expert user to not bother with mount options. I use this for 4 month now and never had a problem with setting the default subvol.

@triplem: The fstab is not in use at this early stage of boot. The only params which take effect are the kernel boot options from Grub or Syslinux. Also the subvol option in fstab can be misleading, when you boot from __rollback. When I started working with btrfs, I had problems on auto-generating the grub.conf from fstab, that's why I decided to keep it as simple as possible.

visit1985 commented 11 years ago

@xtfxme: Ahh yes... I would appreciate adding me to the repo. I can also work on the new features in a different branch.

anthonyrisinger commented 11 years ago

@visit1985 that's fine i'll go ahead and add you; except for simple bugfixes, i would appreciate it if you would still work out of your own github repos, and still open pull requests, even if you expect to merge it yourself... it's a good habit to have and it leaves a clear trail.

CLOSED :)