search

anthonyshort / deku

Render interfaces using pure functions and virtual DOM
https://github.com/anthonyshort/deku/tree/master/docs
3.41k stars 130 forks source link

Resolve remaining linter errors #282

Closed tejasmanohar closed 8 years ago

tejasmanohar commented 8 years ago

The only questionable change here (imo) is L#1161-1163 of render.js on 45d7a7f643e58b3cef011a778aeea0968a3708f6. I assume the intent with using Function#call here was to prevent exposing scope of the host / outer function (the one you're calling it in)... but maybe the original author can comment on that? ;)

tejasmanohar commented 8 years ago

On a side note, I bet it'd be useful to add linting to your CI setup (#283)