search

anthonyshort / deku

Render interfaces using pure functions and virtual DOM
https://github.com/anthonyshort/deku/tree/master/docs
3.41k stars 130 forks source link

Fix ci #364

Closed anthonyshort closed 8 years ago

anthonyshort commented 8 years ago

The tests breaking all the time makes it really hard to just quickly accept useful PRs. This runs tests using tape-run instead of zuul. We can manually run the browser tests when needed.

rstacruz commented 8 years ago

tape-run doesn't seem to support Linux. how about jsdom? (edit: seems to work now!)

rstacruz commented 8 years ago

or, hmm. tape-run may be able to work with PhantomJS

anthonyshort commented 8 years ago

I can't actually tell if the tests ran in Travis haha. They might not actually be working. The tape-run docs say you need to add some extra stuff to the travis config to get it to work. Only reason I'm preferring tape-run over jsdom is that it's just a command and we don't need another config :P

rstacruz commented 8 years ago

It seems to work, but for some reason GitBook is saying the build failed (not that it should concern itself of it, but whatevs).

anthonyshort commented 8 years ago

I'll merge it and see what happens :D