Closed rstacruz closed 8 years ago
Probably going to need a bigger test case :P
Can you try this again with rc11?
still getting the same.
I'm also getting this:
Uncaught TypeError: Failed to execute 'removeChild' on 'Node': parameter 1 is not of type 'Node'.
removeChild: function removeChild(index) {
DOMElement.removeChild(childNodes[index]);
},
likely because I have nulls in my render()
:
return <div class='app'>
{ action ?
<div class='nav'>
<NavigationShow action={ route.get('action') } />
</div> : null }
{ context.get('_loading') ?
<LoadingIndicator /> : null }
{ context.get('error') ?
<ErrorsShow error={ context.get('error') } /> : null }
...
Also this, in a case where many DOM elements are to be removed:
Uncaught TypeError: Cannot read property 'type' of null
var isThunk = exports.isThunk = function isThunk(node) {
return node.type === '#thunk'; // <===
};
isThunk @ index.js:107 removeThunks @ patch.js:109 removeThunks @ patch.js:122 ... replaceNode @ patch.js:91
I'll try to contribute isolated test cases when I get the time.
I added the ability to render null
last night. So hopefully this fixes all of these issues.
I'm not sure what's causing this exactly: