search

anthonyshort / deku

Render interfaces using pure functions and virtual DOM
https://github.com/anthonyshort/deku/tree/master/docs
3.41k stars 130 forks source link

fixed build:lint globs #397

Closed axdg closed 8 years ago

axdg commented 8 years ago

The npm build:lint globs weren't recursive, so standard was only checking the top level folder in src and test. I fixed this and fixed the lint while I was at it.

anthonyshort commented 8 years ago

Thanks! I can't merge this right now because I've reverted the changes to app/index.js with the pre-rendered fixes until we get that sorted. So I've just copied the lint fixes into another commit.

axdg commented 8 years ago

Hi @anthonyshort

No problem, I can just close the PR. That seems easier.

Not sure if this is the right channel for this - I'm about to start a small project and would really like to use Deku 2.0 in place of React. Do you guys have an idea of when are going to ship a stable 2.0 / what features are left? Noticed that you have a branch where you've removed context, have you nailed down an API that will replace it? Maybe #346. +1 for anything that allows me to memoize renders in userland.

This module is awesome by the way, I've dived into the source over the past few nights and, despite the fact that I've never looked at the internals of a vdom library, I'm able to get what's going on pretty easily.

anthonyshort commented 8 years ago

I want to get it out this week. It's been too long in limbo. Removing context is probably the best bet to keep things simple. It creates a bunch of technical issues like sub-tree rendering that I'd rather just solve in a v3.

Feature-wise it's pretty solid now. There shouldn't be any more rendering bugs so it's fairly stable. I'll lock down the APIs for v2 and remove context for now, then we'll ship it.

axdg commented 8 years ago

Awesome, thanks.