search

anthonywebb / homebridge-cbus

CBus plugin for homebridge
MIT License
35 stars 20 forks source link

address double-command issue #30

Closed simonhac closed 7 years ago

simonhac commented 7 years ago

addressed issue where changing the brightness level via the Home app could result in a double command, with the first one likely to set the level briefly to 100%.

simonhac commented 7 years ago

this addresses #24.

as @anthonywebb wrote:

If we change this it should be tested pretty extensively to ensure it is working properly.

simonhac commented 7 years ago

stop press! found a bug:

assert.js:85
  throw new assert.AssertionError({
  ^
AssertionError: false == true
    at Console.assert (console.js:95:23)
    at Timeout.setTimeout (/Users/simon/dev/homebridge-cbus/accessories/light-accessory.js:60:12)
    at ontimeout (timers.js:365:14)
    at tryOnTimeout (timers.js:237:5)
    at Timer.listOnTimeout (timers.js:207:5)
simonhac commented 7 years ago

above bug fixed in PR #34 -- ready to merge both.

(it appears that Siri uses true/false but the Home app uses 1/0 -- odd!)