Open kousu opened 6 years ago
Making the gcc-suggested change
[kousu@requiem rtl8723bs]$ git diff
diff --git a/os_dep/linux/ioctl_cfg80211.c b/os_dep/linux/ioctl_cfg80211.c
index 66b0870..c75f39f 100644
--- a/os_dep/linux/ioctl_cfg80211.c
+++ b/os_dep/linux/ioctl_cfg80211.c
@@ -3951,7 +3951,7 @@ static int rtw_cfg80211_add_monitor_if(_adapter *padapter, char *name, struct ne
mon_ndev->type = ARPHRD_IEEE80211_RADIOTAP;
strncpy(mon_ndev->name, name, IFNAMSIZ);
mon_ndev->name[IFNAMSIZ - 1] = 0;
- mon_ndev->destructor = rtw_ndev_destructor;
+ mon_ndev->priv_destructor = rtw_ndev_destructor;^M
#if (LINUX_VERSION_CODE>=KERNEL_VERSION(2,6,29))
mon_ndev->netdev_ops = &rtw_cfg80211_monitor_if_ops;
[kousu@requiem rtl8723bs]$
fixes it:
[kousu@requiem rtl8723bs]$ vi os_dep/linux/ioctl_cfg80211.c
[kousu@requiem rtl8723bs]$ make
make ARCH=x86_64 CROSS_COMPILE= -C /lib/modules/4.11.9-1-ARCH/build M=/home/kousu/rtl8723bs modules
make[1]: Entering directory '/usr/lib/modules/4.11.9-1-ARCH/build'
CC [M] /home/kousu/rtl8723bs/os_dep/linux/ioctl_cfg80211.o
CC [M] /home/kousu/rtl8723bs/os_dep/linux/rtw_cfgvendor.o
CC [M] /home/kousu/rtl8723bs/os_dep/linux/wifi_regd.o
CC [M] /home/kousu/rtl8723bs/os_dep/linux/rtw_android.o
CC [M] /home/kousu/rtl8723bs/os_dep/linux/rtw_proc.o
CC [M] /home/kousu/rtl8723bs/os_dep/linux/ioctl_mp.o
CC [M] /home/kousu/rtl8723bs/os_dep/linux/custom_gpio_linux.o
CC [M] /home/kousu/rtl8723bs/hal/hal_intf.o
CC [M] /home/kousu/rtl8723bs/hal/hal_com.o
CC [M] /home/kousu/rtl8723bs/hal/hal_com_phycfg.o
CC [M] /home/kousu/rtl8723bs/hal/hal_phy.o
CC [M] /home/kousu/rtl8723bs/hal/hal_dm.o
CC [M] /home/kousu/rtl8723bs/hal/hal_btcoex.o
In file included from /home/kousu/rtl8723bs/hal/hal_btcoex.c:26:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:69:0: warning: "RT_TRACE" redefined
#define RT_TRACE(dbgtype, dbgflag, printstr)
In file included from /home/kousu/rtl8723bs/include/drv_types.h:65:0,
from /home/kousu/rtl8723bs/include/../hal/phydm/phydm_types.h:172,
from /home/kousu/rtl8723bs/include/../hal/phydm/phydm_precomp.h:24,
from /home/kousu/rtl8723bs/include/hal_data.h:25,
from /home/kousu/rtl8723bs/hal/hal_btcoex.c:24:
/home/kousu/rtl8723bs/include/rtw_debug.h:154:0: note: this is the location of the previous definition
#define RT_TRACE(_Comp, _Level, Fmt) do{}while(0)
CC [M] /home/kousu/rtl8723bs/hal/hal_mp.o
/home/kousu/rtl8723bs/hal/hal_mp.c: In function 'mpt_SetRFPath_8723B':
/home/kousu/rtl8723bs/hal/hal_mp.c:987:6: warning: statement will never be executed [-Wswitch-unreachable]
u8 p = 0, i = 0;
^
CC [M] /home/kousu/rtl8723bs/hal/hal_hci/hal_sdio.o
CC [M] /home/kousu/rtl8723bs/hal/led/hal_sdio_led.o
CC [M] /home/kousu/rtl8723bs/hal/HalPwrSeqCmd.o
CC [M] /home/kousu/rtl8723bs/hal/rtl8723b/Hal8723BPwrSeq.o
CC [M] /home/kousu/rtl8723bs/hal/rtl8723b/rtl8723b_sreset.o
CC [M] /home/kousu/rtl8723bs/hal/rtl8723b/rtl8723b_hal_init.o
CC [M] /home/kousu/rtl8723bs/hal/rtl8723b/rtl8723b_phycfg.o
CC [M] /home/kousu/rtl8723bs/hal/rtl8723b/rtl8723b_rf6052.o
CC [M] /home/kousu/rtl8723bs/hal/rtl8723b/rtl8723b_dm.o
CC [M] /home/kousu/rtl8723bs/hal/rtl8723b/rtl8723b_rxdesc.o
CC [M] /home/kousu/rtl8723bs/hal/rtl8723b/rtl8723b_cmd.o
CC [M] /home/kousu/rtl8723bs/hal/rtl8723b/sdio/sdio_halinit.o
CC [M] /home/kousu/rtl8723bs/hal/rtl8723b/sdio/rtl8723bs_led.o
CC [M] /home/kousu/rtl8723bs/hal/rtl8723b/sdio/rtl8723bs_xmit.o
CC [M] /home/kousu/rtl8723bs/hal/rtl8723b/sdio/rtl8723bs_recv.o
CC [M] /home/kousu/rtl8723bs/hal/rtl8723b/sdio/sdio_ops.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_debug.o
In file included from /home/kousu/rtl8723bs/hal/phydm/phydm_precomp.h:82:0,
from /home/kousu/rtl8723bs/hal/phydm/phydm_debug.c:26:
/home/kousu/rtl8723bs/hal/phydm/phydm_debug.c: In function 'phydm_BasicProfile':
/home/kousu/rtl8723bs/hal/phydm/phydm_debug.h:253:11: warning: '%s' directive argument is null [-Wformat-truncation=]
used+=snprintf msg;\
/home/kousu/rtl8723bs/hal/phydm/phydm_debug.c:1001:2: note: in expansion of macro 'PHYDM_SNPRINTF'
PHYDM_SNPRINTF((output + used, out_len - used, " %-35s: %s\n", "PHY Parameter Commit by", commit_by));
^~~~~~~~~~~~~~
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_antdiv.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_antdect.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_interface.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_hwconfig.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/halphyrf_ce.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_edcaturbocheck.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_dig.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_pathdiv.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_rainfo.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_dynamicbbpowersaving.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_powertracking_ce.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_dynamictxpower.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_adaptivity.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_cfotracking.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_noisemonitor.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_acs.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/phydm_beamforming.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/txbf/halcomtxbf.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/txbf/haltxbfinterface.o
CC [M] /home/kousu/rtl8723bs/hal/btc/HalBtc8192e1Ant.o
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8192e1Ant.c:14:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:69:0: warning: "RT_TRACE" redefined
#define RT_TRACE(dbgtype, dbgflag, printstr)
In file included from /home/kousu/rtl8723bs/include/drv_types.h:65:0,
from /home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:23,
from /home/kousu/rtl8723bs/hal/btc/HalBtc8192e1Ant.c:14:
/home/kousu/rtl8723bs/include/rtw_debug.h:154:0: note: this is the location of the previous definition
#define RT_TRACE(_Comp, _Level, Fmt) do{}while(0)
CC [M] /home/kousu/rtl8723bs/hal/btc/HalBtc8192e2Ant.o
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8192e2Ant.c:14:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:69:0: warning: "RT_TRACE" redefined
#define RT_TRACE(dbgtype, dbgflag, printstr)
In file included from /home/kousu/rtl8723bs/include/drv_types.h:65:0,
from /home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:23,
from /home/kousu/rtl8723bs/hal/btc/HalBtc8192e2Ant.c:14:
/home/kousu/rtl8723bs/include/rtw_debug.h:154:0: note: this is the location of the previous definition
#define RT_TRACE(_Comp, _Level, Fmt) do{}while(0)
CC [M] /home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.o
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:14:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:69:0: warning: "RT_TRACE" redefined
#define RT_TRACE(dbgtype, dbgflag, printstr)
In file included from /home/kousu/rtl8723bs/include/drv_types.h:65:0,
from /home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:23,
from /home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:14:
/home/kousu/rtl8723bs/include/rtw_debug.h:154:0: note: this is the location of the previous definition
#define RT_TRACE(_Comp, _Level, Fmt) do{}while(0)
/home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c: In function 'halbtc8723b1ant_set_ant_path':
/home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:779:7: warning: 'halbtc8723b1ant_set_ant_path(): we don't need to wait for H2C command completion because of Fw download fail!!!
' directive output truncated writing 112 bytes into a region of size 100 [-Wformat-truncation=]
("halbtc8723b1ant_set_ant_path(): we don't need to wait for H2C command completion because of Fw download fail!!!\n"));
^
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:14:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:29:18: note: 'snprintf' output 113 bytes into a destination of size 100
#define rsprintf snprintf
/home/kousu/rtl8723bs/hal/btc/HalBtcOutSrc.h:9:24: note: in expansion of macro 'rsprintf'
#define BTC_SPRINTF rsprintf
^~~~~~~~
/home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:778:6: note: in expansion of macro 'BTC_SPRINTF'
BTC_SPRINTF(trace_buf , BT_TMP_BUF_SIZE,
^~~~~~~~~~~
/home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:817:7: warning: 'halbtc8723b1ant_set_ant_path(): we don't need to wait for H2C command completion because of Fw download fail!!!
' directive output truncated writing 112 bytes into a region of size 100 [-Wformat-truncation=]
("halbtc8723b1ant_set_ant_path(): we don't need to wait for H2C command completion because of Fw download fail!!!\n"));
^
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:14:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:29:18: note: 'snprintf' output 113 bytes into a destination of size 100
#define rsprintf snprintf
/home/kousu/rtl8723bs/hal/btc/HalBtcOutSrc.h:9:24: note: in expansion of macro 'rsprintf'
#define BTC_SPRINTF rsprintf
^~~~~~~~
/home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:816:6: note: in expansion of macro 'BTC_SPRINTF'
BTC_SPRINTF(trace_buf , BT_TMP_BUF_SIZE,
^~~~~~~~~~~
/home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:863:8: warning: 'halbtc8723b1ant_set_ant_path(): we don't need to wait for H2C command completion because of Fw download fail!!!
' directive output truncated writing 112 bytes into a region of size 100 [-Wformat-truncation=]
("halbtc8723b1ant_set_ant_path(): we don't need to wait for H2C command completion because of Fw download fail!!!\n"));
^
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:14:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:29:18: note: 'snprintf' output 113 bytes into a destination of size 100
#define rsprintf snprintf
/home/kousu/rtl8723bs/hal/btc/HalBtcOutSrc.h:9:24: note: in expansion of macro 'rsprintf'
#define BTC_SPRINTF rsprintf
^~~~~~~~
/home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:862:7: note: in expansion of macro 'BTC_SPRINTF'
BTC_SPRINTF(trace_buf , BT_TMP_BUF_SIZE,
^~~~~~~~~~~
/home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c: In function 'halbtc8723b1ant_psd_antenna_detection':
/home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:3347:105: warning: ', wlpsd_sweep_count = ' directive output truncated writing 22 bytes into a region of size 10 [-Wformat-truncation=]
"xxxxxxxxxxxxxxxx AntennaDetect(), wlpsd_cent_freq=%d, wlpsd_offset = %d, wlpsd_span = %d, wlpsd_sweep_count = %d\n",
~~~~~~~~~~^~~~~~~~~~~~
/home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:3347:5: note: using the range [-2147483648, 2147483647] for directive argument
"xxxxxxxxxxxxxxxx AntennaDetect(), wlpsd_cent_freq=%d, wlpsd_offset = %d, wlpsd_span = %d, wlpsd_sweep_count = %d\n",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:14:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:29:18: note: 'snprintf' output between 115 and 125 bytes into a destination of size 100
#define rsprintf snprintf
/home/kousu/rtl8723bs/hal/btc/HalBtcOutSrc.h:9:24: note: in expansion of macro 'rsprintf'
#define BTC_SPRINTF rsprintf
^~~~~~~~
/home/kousu/rtl8723bs/hal/btc/HalBtc8723b1Ant.c:3346:4: note: in expansion of macro 'BTC_SPRINTF'
BTC_SPRINTF(trace_buf, BT_TMP_BUF_SIZE,
^~~~~~~~~~~
CC [M] /home/kousu/rtl8723bs/hal/btc/HalBtc8723b2Ant.o
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8723b2Ant.c:14:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:69:0: warning: "RT_TRACE" redefined
#define RT_TRACE(dbgtype, dbgflag, printstr)
In file included from /home/kousu/rtl8723bs/include/drv_types.h:65:0,
from /home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:23,
from /home/kousu/rtl8723bs/hal/btc/HalBtc8723b2Ant.c:14:
/home/kousu/rtl8723bs/include/rtw_debug.h:154:0: note: this is the location of the previous definition
#define RT_TRACE(_Comp, _Level, Fmt) do{}while(0)
CC [M] /home/kousu/rtl8723bs/hal/btc/HalBtc8812a1Ant.o
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8812a1Ant.c:14:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:69:0: warning: "RT_TRACE" redefined
#define RT_TRACE(dbgtype, dbgflag, printstr)
In file included from /home/kousu/rtl8723bs/include/drv_types.h:65:0,
from /home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:23,
from /home/kousu/rtl8723bs/hal/btc/HalBtc8812a1Ant.c:14:
/home/kousu/rtl8723bs/include/rtw_debug.h:154:0: note: this is the location of the previous definition
#define RT_TRACE(_Comp, _Level, Fmt) do{}while(0)
CC [M] /home/kousu/rtl8723bs/hal/btc/HalBtc8812a2Ant.o
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8812a2Ant.c:15:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:69:0: warning: "RT_TRACE" redefined
#define RT_TRACE(dbgtype, dbgflag, printstr)
In file included from /home/kousu/rtl8723bs/include/drv_types.h:65:0,
from /home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:23,
from /home/kousu/rtl8723bs/hal/btc/HalBtc8812a2Ant.c:15:
/home/kousu/rtl8723bs/include/rtw_debug.h:154:0: note: this is the location of the previous definition
#define RT_TRACE(_Comp, _Level, Fmt) do{}while(0)
CC [M] /home/kousu/rtl8723bs/hal/btc/HalBtc8821a1Ant.o
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8821a1Ant.c:14:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:69:0: warning: "RT_TRACE" redefined
#define RT_TRACE(dbgtype, dbgflag, printstr)
In file included from /home/kousu/rtl8723bs/include/drv_types.h:65:0,
from /home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:23,
from /home/kousu/rtl8723bs/hal/btc/HalBtc8821a1Ant.c:14:
/home/kousu/rtl8723bs/include/rtw_debug.h:154:0: note: this is the location of the previous definition
#define RT_TRACE(_Comp, _Level, Fmt) do{}while(0)
CC [M] /home/kousu/rtl8723bs/hal/btc/HalBtc8821a2Ant.o
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8821a2Ant.c:14:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:69:0: warning: "RT_TRACE" redefined
#define RT_TRACE(dbgtype, dbgflag, printstr)
In file included from /home/kousu/rtl8723bs/include/drv_types.h:65:0,
from /home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:23,
from /home/kousu/rtl8723bs/hal/btc/HalBtc8821a2Ant.c:14:
/home/kousu/rtl8723bs/include/rtw_debug.h:154:0: note: this is the location of the previous definition
#define RT_TRACE(_Comp, _Level, Fmt) do{}while(0)
CC [M] /home/kousu/rtl8723bs/hal/btc/HalBtc8821aCsr2Ant.o
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8821aCsr2Ant.c:15:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:69:0: warning: "RT_TRACE" redefined
#define RT_TRACE(dbgtype, dbgflag, printstr)
In file included from /home/kousu/rtl8723bs/include/drv_types.h:65:0,
from /home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:23,
from /home/kousu/rtl8723bs/hal/btc/HalBtc8821aCsr2Ant.c:15:
/home/kousu/rtl8723bs/include/rtw_debug.h:154:0: note: this is the location of the previous definition
#define RT_TRACE(_Comp, _Level, Fmt) do{}while(0)
CC [M] /home/kousu/rtl8723bs/hal/btc/HalBtc8703b1Ant.o
In file included from /home/kousu/rtl8723bs/hal/btc/HalBtc8703b1Ant.c:14:0:
/home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:69:0: warning: "RT_TRACE" redefined
#define RT_TRACE(dbgtype, dbgflag, printstr)
In file included from /home/kousu/rtl8723bs/include/drv_types.h:65:0,
from /home/kousu/rtl8723bs/hal/btc/Mp_Precomp.h:23,
from /home/kousu/rtl8723bs/hal/btc/HalBtc8703b1Ant.c:14:
/home/kousu/rtl8723bs/include/rtw_debug.h:154:0: note: this is the location of the previous definition
#define RT_TRACE(_Comp, _Level, Fmt) do{}while(0)
CC [M] /home/kousu/rtl8723bs/hal/phydm/rtl8723b/halhwimg8723b_bb.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/rtl8723b/halhwimg8723b_mac.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/rtl8723b/halhwimg8723b_rf.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/rtl8723b/halhwimg8723b_fw.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/rtl8723b/halhwimg8723b_mp.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/rtl8723b/phydm_regconfig8723b.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/rtl8723b/halphyrf_8723b_ce.o
CC [M] /home/kousu/rtl8723bs/hal/phydm/rtl8723b/phydm_rtl8723b.o
CC [M] /home/kousu/rtl8723bs/platform/platform_ops.o
CC [M] /home/kousu/rtl8723bs/core/rtw_mp.o
CC [M] /home/kousu/rtl8723bs/core/rtw_mp_ioctl.o
CC [M] /home/kousu/rtl8723bs/core/rtw_bt_mp.o
LD [M] /home/kousu/rtl8723bs/8723bs.o
Building modules, stage 2.
MODPOST 1 modules
CC /home/kousu/rtl8723bs/8723bs.mod.o
LD [M] /home/kousu/rtl8723bs/8723bs.ko
make[1]: Leaving directory '/usr/lib/modules/4.11.9-1-ARCH/build'
[kousu@requiem rtl8723bs]$
I just tried installing this driver (via AUR, so actually I'm using @muhviehstah's fork, but I can't post issues there since it's a fork) and got this error:
the log mentioned is
The same error appears if I try a manual compilation: