anthraxx / intellij-awesome-console

IntelliJ IDEA plugin: awesome console finally makes links in your console at least 200% more awesome!
MIT License
159 stars 40 forks source link

Strict matched sources by path #42

Closed Rublis closed 5 years ago

Rublis commented 5 years ago

Currently in framework we use we got multiple groovy classes with same name, but with different path. Problem with awesome-console was, that shows all same basename classes regardless of path. So my aproach is that I try to limit matched sources based on path as well

twidi commented 5 years ago

I'd love this to be integrated. I use another framework, Django (in Python) and I guess that it's like a lot of frameworks: files names are often the same, by convention.

(This fixes #36 i guess)

Rublis commented 5 years ago

Thanks! Yep, it seems so that this fixes #36, and yes, I guess there are plenty frameworks that uses such feature, it's convenient way to implement some kind of object lifecycle.

If You are interested I can provide prebuilded plugin jar, so You can simply use it, till this fix get's mainlined.

twidi commented 5 years ago

I would love that :) Many times a day I want to use this plugin, but useless because of this issue (in my work and main personal project, I have dozens of models.py files.... )

If you package it this way, it would be installable via the "Install plugin from disk" in the plugin window, am I right?

Great work btw, If I had any knowledge in java I would have worked on it! Thanks a lot!

Rublis commented 5 years ago

No problem! I made a alpha-release under my fork: https://github.com/Rublis/intellij-awesome-console/releases/tag/0.1337.6

Feel free to comment if something is not working as expected. I have tested it under my linux machine. And just cases which wasn't working fine for me.

anthraxx commented 5 years ago

Sorry for the long delay, I have been involved massively in other projects. I will revisit the issues and PR and get out a new version as soon as possible. Thanks for the PR

Rublis commented 5 years ago

Sorry for the long delay, I have been involved massively in other projects. I will revisit the issues and PR and get out a new version as soon as possible. Thanks for the PR

Great! Thanks! Take Your time! :+1: Thanks for developing this plugin! It's really helpful!

twidi commented 5 years ago

@Rublis thanks a lot. I disabled the original plugin, installed your, restarted my IDE but I still have the old behavior, see on the attached screenshot.

Anything I can do to help you on this?

selection_011

Rublis commented 5 years ago

Problem is that I'm using "raw" pathes without resolving them. By that I mean: ~ is not same as home dir, or . is not current dir. Any case I just did small adjustment and updated same release jar file. Please try again. It should work also for pathes with "./" and "~/". Thing is that I'm still is not resolving them, but I simply cut them of.

twidi commented 5 years ago

OMG it works, thanks a lot!

Rublis commented 5 years ago

OMG it works, thanks a lot!

No problems! ;)

Rublis commented 5 years ago

changed according previous comments. @twidi could You please try: https://github.com/Rublis/intellij-awesome-console/releases/tag/0.1337.7

twidi commented 5 years ago

@Rublis it seems to work, thanks!

Rublis commented 5 years ago

Great, Thanks @twidi

anthraxx commented 5 years ago

Looks good, will merge and release an update one back to my laptop in 3 days.

Please don't tag same version schema as that overlaps with here, you can use chars like a b c for temporary fork releases without confusion and overlap.

Thanks for the pull request, looks good now

Rublis commented 5 years ago

Looks good, will merge and release an update one back to my laptop in 3 days. Please don't tag same version schema as that overlaps with here, you can use chars like a b c for temporary fork releases without confusion and overlap. Thanks for the pull request, looks good now

Great! Thanks! And thanks for tip.

frsantos commented 5 years ago

Hi @anthraxx, any chance you can merge and release this PR? I love your plugin, but without this PR it's not very useful. Rails, as other frameworks, uses many files with the same name.

twidi commented 5 years ago

@frsantos you can use the jar in the realese given a few months back ( https://github.com/Rublis/intellij-awesome-console/releases/tag/0.1337.7 )

anthraxx commented 5 years ago

applied in master. thanks