anthraxx / intellij-awesome-console

IntelliJ IDEA plugin: awesome console finally makes links in your console at least 200% more awesome!
MIT License
159 stars 40 forks source link

Add support for windows paths #52

Closed bertyhell closed 3 years ago

bertyhell commented 4 years ago

Could you add support for windows paths containing forward slashes?

example tslint outputs paths like this: C:/Users/bert/Documents/my-file.const.ts:37:1

If i try to open one of these i get: image

I'm guessing replacing the forward slashes by backward slashes might fix the issue

hoeni commented 4 years ago

Same here, but I suppose the problem is due to the passed colon and line number at the end. However, it would be a great help to have this fixed, as that's the way Angular's ng lint is producing it's output: ERROR: c:/users/x/y/src/app/shared/versionspane/versionspane.component.html:10:29 - Missing whitespace in interpolation start; expecting {{ expr }}

bertyhell commented 4 years ago

@hoeni I created a PR with a fix. Let's hope the maintainer merges it. https://github.com/anthraxx/intellij-awesome-console/pull/53

MaxmaxmaximusGitHub commented 4 years ago

image

bertyhell commented 4 years ago

@MaxmaxmaximusGitHub What should i be looking at in your image? That map files are not mapped correctly? Is this my pr that you are running?

MaxmaxmaximusGitHub commented 4 years ago

@bertyhell static\ is part of path, it should be highlighted at blue, and be part of the link

Is this my pr that you are running?

yes of course

bertyhell commented 4 years ago

@MaxmaxmaximusGitHub i'm not sure if this "static part not being highlighted" is part of this PR, since the regex that i changed does correctly inlcude it

The original regex selected static\ but didn't select c:\

image

The regex in my PR does correctly select static\ and also correctly selects c:\

image

The static issue might be a bug somewhere else in the code, but unrelated to my PR

bluelovers commented 3 years ago

image

anthraxx commented 3 years ago

Some of these cases should be handled by f5177c40566b6ff3821eec7669cf84e9a4ebde72 (no whitespace through) new cases should be opened separately after the next release