search

anthraxx / intellij-awesome-console

IntelliJ IDEA plugin: awesome console finally makes links in your console at least 200% more awesome!
MIT License
159 stars 40 forks source link

Fix: add windows support for tslint path format #53

Closed bertyhell closed 3 years ago

bertyhell commented 4 years ago

closes: https://github.com/anthraxx/intellij-awesome-console/issues/52

Tested with:

ERROR: C:/Users/ControlsSidebar.tsx:216:17 - Calls to 'console' are not allowed.

Result:

match: C:/Users/ControlsSidebar.tsx:216:17
row: 216
col: 17
path: C:/Users/ControlsSidebar.tsx

@anthraxx mention for attention

bertyhell commented 4 years ago

@anthraxx any chance you could have a look at merging this?

anthraxx commented 4 years ago

Sure but this only adds a group to the regex, why does this change any of the behavior?

bertyhell commented 4 years ago

Sure but this only adds a group to the regex, why does this change any of the behavior?

@anthraxx because the pipe symbol has a different meaning when it is found within () I think you probably meant to write (\\\\|/) instead of \\\\|/

since (\\\\|/) will match either the string "\\" or the string "/" but \\\\|/ will try to match the literal string: "\\|/"

anthraxx commented 4 years ago

Yes, that's a very good catch actually. I will test this on some envs and get it merged. Thanks

anthraxx commented 3 years ago

applied and fixed in f5177c40566b6ff3821eec7669cf84e9a4ebde72