anthraxx / intellij-awesome-console

IntelliJ IDEA plugin: awesome console finally makes links in your console at least 200% more awesome!
MIT License
159 stars 40 forks source link

Navigation to line sometimes incorrect - does not account for folded lines #79

Closed dmeibusch closed 2 years ago

dmeibusch commented 3 years ago

Awesome plugin, thank you.

Navigating to a line does not take into account any folded (https://www.jetbrains.com/help/idea/code-folding-settings.html) lines above.

Workaround: Expand all folded text in the file before clicking on the link. Code | Folding | Expand All.

This issue might also account for some other issues that indicate unknown "inconsistent" behaviour.

Intellij 20.3.3 Awesome Console 0.1337.11

anthraxx commented 3 years ago

Duplicate of #75 If you have a intellij API idea, feel free to point out. The navigation API's do not support "raw" line numbers.

dmeibusch commented 3 years ago

Ah, I missed the #75 duplicate - I was only looking at closed issues. My bad. I haven't used the navigation APIs, however ever I do recall the same issues when I was working with the Eclipse API equivalents. :-(

jlous commented 3 years ago

@anthraxx: Editor.logicalToVisualPosition should be be helpful for calculating the correct line

anthraxx commented 2 years ago

Fixed by 38e16d3655097dfcfd52fe1e7ec5b778f83b5e76