anthwlock / untrunc

Restore a truncated mp4/mov. Improved version of ponchio/untrunc
GNU General Public License v2.0
1.9k stars 182 forks source link

Dockerfile refactor #25

Closed serl closed 5 years ago

serl commented 5 years ago

Hello, I refactored a little bit the Dockerfile following some best practices:

Probably the travis configuration should be updated as well.

Thanks!

anthwlock commented 5 years ago

Hey, thank you! I have pushed your commit and some additional changes on new_docker. The Makefile uses git for determining untrunc's version, so it needs to be installed.

By using multi-stage builds I managed

But since docker keeps previous stages for caching, they have be deleted explicitly.

It looks like rm -rf /var/lib/apt/lists is not needed:

Note: The official Debian and Ubuntu images automatically run apt-get clean, so explicit invocation is not required.

serl commented 5 years ago

Wow, great job!

I think rm -rf /var/lib/apt/lists is still needed. If I understood correctly, apt-get clean will not remove that directory: https://askubuntu.com/a/894822.

anthwlock commented 5 years ago

You were right, images are now 20MB smaller. Thanks!