anti-work / shortest

Have AI write and update tests for you
https://shortest.com
MIT License
187 stars 21 forks source link

fix: improve GitHub Actions detection messaging #77

Closed bjornpagen closed 4 weeks ago

bjornpagen commented 4 weeks ago

Problem

When someone starts using shortest for the first time, they may not realize shortest actually reads their build logs to try to autocorrect tests. Currently, if no test runners are detected by shortest, it fails silently without notifying the user.

Solution:

Clarify to users that GitHub Actions is needed for test log analysis by adding PR number and repo details to the error message when Actions is not enabled. This helps users understand why Actions access is required for the test-fixing functionality to work properly.

Screenshot 2024-10-27 at 8 26 38 PM
vercel[bot] commented 4 weeks ago

@bjornpagen is attempting to deploy a commit to the Antiwork Team on Vercel.

A member of the Team first needs to authorize it.

m2rads commented 4 weeks ago

So this issue happens even if you have workflow and actions:read scope added in Clerk?

image

bjornpagen commented 4 weeks ago

So this issue happens even if you have workflow and actions:read scope added in Clerk?

image

I don't believe either of these permissions are needed to read GitHub Actions logs. repo permissions appear to be enough.

This new toast will only appear if you've created a new repo without any GitHub Actions set up. For example, when I forked anti-work/shortest into bjornpagen/shortest, GitHub Actions was not automatically set up. Once I set up GitHub Actions, this toast notification went away.

slavingia commented 4 weeks ago

Good point, can't know if tests are failing without GitHub actions