search

antialiasis / favorite-picker

A tool to sort things in order of preference.
MIT License
128 stars 148 forks source link

struggling with filtering #23

Closed PolaricPotato closed 11 months ago

PolaricPotato commented 1 year ago

so this is my first time coding so i dont really know what im doing basically im trying to filter survivor contestants by ssn but when i added the filters for season 1, all of the options vanished and i dont know what i did wrong or how to fix it

image

`<!DOCTYPE html>

Picker

Favorite Survivor Picker

Original source code by antialiasis with instructions here, based off of the Favorite Pokemon Picker

Updated up to Survivor 44

Potato was here

Number of contestants displayed:

Options:

Include seasons:

Times played:

`

antialiasis commented 1 year ago

You're missing a comma at the end of the line that goes recurringOnly: '#recurring-only'. Let me know if it works if you add that.

PolaricPotato commented 1 year ago

You're missing a comma at the end of the line that goes recurringOnly: '#recurring-only'. Let me know if it works if you add that.

added the comma and it still doesnt work

antialiasis commented 1 year ago

Looks like you're also missing a comma after maxBatchSize: 30.

PolaricPotato commented 1 year ago

that comma didnt fix it either

antialiasis commented 1 year ago

Looks like you have more missing commas in your item definitions. If you look here:

{id: 's1rich', name: 'Richard Hatch', image: 'survivorfav/s1rich.png', role: '01', recurring: true},
{id: 's1kelly', name: 'Kelly Wigglesworth', image: 'survivorfav/s1kelly.png' role: '01', recurring: true},
{id: 's1rudy', name: 'Rudy Boesch', image: 'survivorfav/s1rudy.png' role: '01', recurring: true},

Rich has a comma after the image filename, but Kelly and Rudy don't, and neither do the subsequent ones. Add those commas back in and try again.

If it fails again, it would be a lot easier to help you if you put your code inside a code block (surround it with three backticks ` on either side); otherwise GitHub tries to parse some of it as Markdown, which garbles the code a bit and means I can't just copy-paste it into a text editor to try it myself.

PolaricPotato commented 1 year ago

that fixed it, thanks