search

antiboredom / videogrep

automatic video supercuts with python
https://antiboredom.github.io/videogrep
Other
3.34k stars 257 forks source link

script -> library #24

Closed djds23 closed 9 years ago

djds23 commented 10 years ago

Hey Sam!

The main change here is removing the interface from the videogrep.py file and moving it to a videogrep_cli.py file. Upon installation using python setup.py install the cli file will be placed into the /usr/bin/. This file will pull the functionality from the videogrep library installed in the user's site-packages.

The main benefit of this is that users can now from videogrep import videogrep and construct commands.

I also added a couple tests, but they do not prove much and frankly need work.

How does this look to you? Have I maintained the spirit of the project?

Thanks, Dean

djds23 commented 10 years ago

Let me write some more tests before merging this!

djds23 commented 9 years ago

@antiboredom thanks for merging this. If you have any questions I'd be happy to work more on this. If you want, @mention me in any bugs you think are related to this PR and I will gladly investigate.