search

antievictionmappingproject / covid-19-map-react

COVID-19 Emergency Tenant Protections Map (refactored to use React!)
13 stars 9 forks source link

Oh navbar #65

Closed jimboweb closed 3 years ago

jimboweb commented 3 years ago

This includes the mobile width but not the navigation links yet. I'm mostly interested in what people think of the look of the hamburger menu.

lisjak commented 3 years ago

@jimboweb Thanks for building out the nav! I merged your work into the dev branch. Your current PR seems to be missing a aemp_hamburger.svg file.import Hamburger from '../assets/aemp_hamburger.svg' breaks in HamburgerMenu.js which causes further issues in NavHeader.js and NavMenu.js so I couldn’t approve your PR without potentially breaking the deployed version of the site.

jimboweb commented 3 years ago

Okay I added the graphic

benjaminben commented 3 years ago

Combined into dev via local merge, will eventually move into master when we merge dev (closing this PR, thanks Jim!)