search

antievictionmappingproject / covid-19-map

COVID-19 Emergency Tenant Protections Map. No longer in use. This is the new repo: https://github.com/antievictionmappingproject/covid-19-map-react
MIT License
16 stars 11 forks source link

search bar phase 2 with new styles - DO NOT MERGE until pr 117 is merged #125

Closed jimboweb closed 4 years ago

jimboweb commented 4 years ago

Branched from timhitchins:style-change, don't merge this until you merge that.

Very kludgy because I'm trying to fix mismatches between different kind of data I'm querying. Not as elegant as it would be if I had more time; things are hard-coded where they should be in separate config files. I'll make a 'pretty' pr when we have the goals for the 31st working.

@djbusstop I'd like it if you could test this from Berlin with language set to de-** to see if you get different results from what I did. For example search for 'Dusseldor[p,f]' and 'Hamburg'.

I'd also love to see how queries from Brazil with the language set to pt-** deals with, say 'Maranhão'.

jimboweb commented 4 years ago

Hey @timhitchins and @bretthalperin thanks for catching the 'county' issue. I figured out why it wasn't showing the data; Bing was returning something like 'Fayette County' but the Carto data just has it listed as 'Fayette' under 'county'. So I put in something to remove 'County' from the string and it works now.

jimboweb commented 4 years ago

@timhitchins I don't know why you're seeing the duplicate data, when I test it it's not happening. Is anyone else getting this?

jimboweb commented 4 years ago

Ok, fixed the unnecessary comma problem