antievictionmappingproject / covid-19-map

COVID-19 Emergency Tenant Protections Map. No longer in use. This is the new repo: https://github.com/antievictionmappingproject/covid-19-map-react
MIT License
15 stars 11 forks source link

Highlight survey link yellow in modal #173

Open brett-halperin opened 3 years ago

brett-halperin commented 3 years ago
highlight yellow

Can we highlight "survey here" in yellow (color code: #FEFF54) in the modal (see image for example)

@benjaminben @timhitchins @isthewhiz

isthewhiz commented 3 years ago

How would I pull this issue down ? In my command line I wrote: git checkout master git pull upstream/master git fetch upstream pull/173/head:pr173 no luck

erinmcel commented 3 years ago

We actually don't need this survey link at all anymore as now the landlord retaliation question has been inserted into the Housing Justice Action survey that is accessible on the main map page.

erinmcel commented 3 years ago

See issue https://github.com/antievictionmappingproject/covid-19-map/issues/172 in terms of renaming the survey in the map to reflect that we're now collecting LL retaliation info there

timhitchins commented 3 years ago

@isthewhiz you wanna try this out and tag me in a PR? If not I can fix this tomorrow likely @erinmcel. Thanks for catching all this.

On Sat, Dec 5, 2020, 12:43 PM Erin McElroy notifications@github.com wrote:

See issue #172 https://github.com/antievictionmappingproject/covid-19-map/issues/172 in terms of renaming the survey in the map to reflect that we're now collecting LL retaliation info there

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/antievictionmappingproject/covid-19-map/issues/173#issuecomment-739413464, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACR5MPVNJFRBZ6MI4GZAQXDSTKLOLANCNFSM4UICX6QQ .

isthewhiz commented 3 years ago

I just saw this email, I have it open and it’s gonna take me a second to see what’s the issue. I’ll take a look at it and if I have any questions I’ll message you Tim.

Sent from my iPhone

On Dec 5, 2020, at 4:28 PM, Tim Hitchins notifications@github.com wrote:

 @isthewhiz you wanna try this out and tag me in a PR? If not I can fix this tomorrow likely @erinmcel. Thanks for catching all this.

On Sat, Dec 5, 2020, 12:43 PM Erin McElroy notifications@github.com wrote:

See issue #172 https://github.com/antievictionmappingproject/covid-19-map/issues/172 in terms of renaming the survey in the map to reflect that we're now collecting LL retaliation info there

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/antievictionmappingproject/covid-19-map/issues/173#issuecomment-739413464, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACR5MPVNJFRBZ6MI4GZAQXDSTKLOLANCNFSM4UICX6QQ .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

isthewhiz commented 3 years ago

Ok, I got it done but need some review to see if I actually did it correctly? Hopefully hear from you guys soon. -Nardo

Sent from my iPhone

On Dec 6, 2020, at 12:23 PM, Isnardo Gandarilla isnardo.gandarilla@gmail.com wrote:

I just saw this email, I have it open and it’s gonna take me a second to see what’s the issue. I’ll take a look at it and if I have any questions I’ll message you Tim.

Sent from my iPhone

On Dec 5, 2020, at 4:28 PM, Tim Hitchins notifications@github.com wrote:

 @isthewhiz you wanna try this out and tag me in a PR? If not I can fix this tomorrow likely @erinmcel. Thanks for catching all this.

On Sat, Dec 5, 2020, 12:43 PM Erin McElroy notifications@github.com wrote:

See issue #172 https://github.com/antievictionmappingproject/covid-19-map/issues/172 in terms of renaming the survey in the map to reflect that we're now collecting LL retaliation info there

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/antievictionmappingproject/covid-19-map/issues/173#issuecomment-739413464, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACR5MPVNJFRBZ6MI4GZAQXDSTKLOLANCNFSM4UICX6QQ .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

brett-halperin commented 3 years ago

I was thinking we could just leave it as is shown in the pic uploaded here, but swap the link to this one: https://airtable.com/shrI5HxbTqEFbk89Y - I realize that'd make it redundant, but the idea was to make it more prominent (once Maya was able to confirm which survey link was the right one). Maybe we could clear this up at the group meeting tomorrow before pushing it. Sorry for all the back and forth... I appreciate you all working on it.

erinmcel commented 3 years ago

Thanks everyone! This all sounds good to me. So yes let’s talk through it tomorrow just to make sure we’re all on the same page with the surveys?

On Sunday, Dec 06, 2020 at 6:04 PM, brett-halperin <notifications@github.com (mailto:notifications@github.com)> wrote:

I was thinking we could just leave it as is shown in the pic uploaded here, but swap the link to this one: https://airtable.com/shrI5HxbTqEFbk89Y (https://urldefense.proofpoint.com/v2/url?u=https-3A__airtable.com_shrI5HxbTqEFbk89Y&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=sCqNE4ZOM_SFlJpK4WWmIg&m=O85EEfVpkFl6RvdOvQwjglXLpukmXGhK3ltIxNJZ2QA&s=gr7-DsLtNyfUYrm1kwB8aKAxRG2J8LinxhsbGuE5j0Q&e=) - I realize that'd make it redundant, but the idea was to make it more prominent (once Maya was able to confirm which survey link was the right one). Maybe we could clear this up at the group meeting tomorrow before pushing it. Sorry for all the back and forth... I appreciate you all working on it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_antievictionmappingproject_covid-2D19-2Dmap_issues_173-23issuecomment-2D739580420&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=sCqNE4ZOM_SFlJpK4WWmIg&m=O85EEfVpkFl6RvdOvQwjglXLpukmXGhK3ltIxNJZ2QA&s=oAyl0IpGj1EMMTDkf4xBhcMoNiyFcljRGJsbwf1rpF8&e=), or unsubscribe (https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AB5DB3M73RNSVKNRSMPGQ7LSTQEWTANCNFSM4UICX6QQ&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=sCqNE4ZOM_SFlJpK4WWmIg&m=O85EEfVpkFl6RvdOvQwjglXLpukmXGhK3ltIxNJZ2QA&s=S0GZoOA5nbTqOnnS2NIRx-Os_I_KeqegfLLtUynDNjE&e=).

djbusstop commented 3 years ago

So far we have added highlighting

To close this issue, we should: