search

antifuchs / gmail-britta

Generate complex gmail filters via a neat little ruby DSL
MIT License
758 stars 33 forks source link

Many forks features and a few more tests #14

Closed jpiasetz closed 8 years ago

jpiasetz commented 8 years ago

Hey @antifuchs, I thought you had mostly moved on from this, so I had been pulling in features off forks. If you're around would probably be good to get these into upstream. Let me know if any of the commits are controversial and I'll rebase them out.

Thanks for the great library saved me a bunch of time earlier this year :+1: !

antifuchs commented 8 years ago

Hah, wow, that's a lot of changes! (And oh my, what a few years away from a repo can mean in terms of unmerged features /-:)

I skimmed the changes, and I think they'll be fine - I'll give them a closer read the next few days & maybe leave a few comments, but I guess the default stance is to merge them. It would be a shame to let this diverge so much from the community's idea of gmail-britta.

Thanks a lot for your work (and to all the other contributors'!) - it totally blows me away that this little tool is useful to people! (-:

antifuchs commented 8 years ago

OK, wow, looking through these, I love all of the changes. Huge thanks for all the contributors - I'm going to merge this, and would appreciate a follow-up PR fleshing out a THANKS file (but I can make one too over the next few weeks). (-: