search

antifuchs / gmail-britta

Generate complex gmail filters via a neat little ruby DSL
MIT License
758 stars 33 forks source link

Added support for to/from in spec with the Gmail XML #6

Closed ryansb closed 8 years ago

ryansb commented 11 years ago

Resubmission of the pull request from earlier, now with 200% more tests.

Review on Reviewable

antifuchs commented 11 years ago

This looks great! I'll look more closely and probably merge tonight. Thanks!

antifuchs commented 11 years ago

Argh, sorry for totally failing to review this on time. The patch set seems to generate a conflict now, too /-:

Can you rebase against master? Thanks in advance!

ryansb commented 11 years ago

Alright, I rebased it and squashed a couple of the less interesting commits for cleaner history.

joshuaspence commented 10 years ago

Is this still going to be merged? I think it would be a welcome addition.

ryansb commented 10 years ago
Is there something additional you want to see in this patch?
neoice commented 9 years ago

I'm planning on experimenting with gmail-britta to replace the ad-hoc filter management I had been doing with vim+git. many of my filters are using from and I want to preserve as much behavior as possible so the resultant filter diff is easier to read.

I'm using gem 'gmail-britta', :git => 'https://github.com/ryansb/gmail-britta.git', :ref => 'feature-tofrom' and I'll report back if I have any problems.

neoice commented 9 years ago

I have now completely replaced the mail filters for my personal and work accounts using feature-tofrom. so far, I've encountered no issues.

ryansb commented 9 years ago

\o/ Happy second birthday, PR#6!