antihax / goesi

Go client for EVE Online ESI and SSO using versioned endpoints
MIT License
79 stars 13 forks source link

Lost of decimal precision on the Price in market #2

Closed dedimarco closed 7 years ago

dedimarco commented 7 years ago

Hi, in the type GetMarketsRegionIdOrders200Ok (in v1, get_markets_region_id_orders_200_ok.go file), Price are float32 type, and loss some precision in decimal, where price are greater than one million ISK. Example : 2 938 863.98 ISK becomes 2 938 864.00 ISK Could you correct some types to use float64 instead ? Other files may be affected by the price problem. Thx.

dedimarco commented 7 years ago

tested with OpenAPI spec version: 0.4.5

dedimarco commented 7 years ago

Here is the list of files that could be impacted :

antihax commented 7 years ago

Thanks,

This is per CCP spec. There is an existing issue for this at their repo: https://github.com/ccpgames/esi-issues/issues/356