search

antimatter-dimensions / notations

Antimatter Dimensions notations
MIT License
41 stars 21 forks source link

Fixes to Standard Notation #320

Closed dan-simon closed 2 years ago

dan-simon commented 2 years ago

Some edge-case behavior was changed, in particular some prefixes were added and formatting of some numbers with -xx- (because of a 1 in the exponent's base 1000 representation, like 1e3003 having exponent 1000) or a "missing type" (because of a 0 in the exponent's base 1000 representation, again like 1e3003 having exponent 1000) were fixed.

dan-simon commented 2 years ago

"Function 'abbreviateStandard' has a complexity of 6. Maximum allowed is 4." How did this increase complexity, I think it's somewhat easier to read. I don't think this needs to be fixed.

"Generic Object Injection Sink" The index is literally always an int.

"Type string trivially inferred from a string literal, remove type annotation" I'm fairly sure this is unfixable; fixing it gives an error that the type can't be inferred.