uxplay aborts on video change on ipad

frigaut commented 2 years ago

Hi there,

I have been using uxplay for over a year and it used to work flawlessly. I have restarted using it and for the past days I have had crashes. When flipping pages or zooming on the ipad, or even with very little activity, I have had uxplay crash on my linux machine with the following error:

$ uxplay
using system MAC address 8c:16:45:30:39:dd
Initialized server socket(s)
Accepted IPv4 client on socket 38
Local: 192.168.1.228
Remote: 192.168.1.236
Open connections: 1
Client identified as User-Agent: AirPlay/605.1
Accepted IPv4 client on socket 40
Local: 192.168.1.228
Remote: 192.168.1.236
Open connections: 2
raop_rtp_mirror starting mirroring
Begin streaming to GStreamer video pipeline
Warning: regular NAL unit, but packet[5] = 0x10 is not 0x00
uxplay: /home/frigaut/.cache/paru/clone/uxplay-git/src/UxPlay/lib/raop_rtp_mirror.c:350: raop_rtp_mirror_thread: Assertion `packet[5] == 0' failed.
fish: Job 1, 'uxplay' terminated by signal SIGABRT (Abort)

is that ringing a bell? It happened 3-4 times for me today. That is, every time I tried it, after 2-10minutes of use.

fduncanh commented 2 years ago

Yes!.

(1) Please post the issue at https://github.com/FDH2/UxPlay where development now takes place (see the README)

(2) The following comment I wrote is clearly not completely correct about packet[5]:

            /* encrypted packets have packet[5] = 0x00 or 0x10, and packet[6]= packet[7] = 0x00; *
             * encrypted packets immediately following an unencrypted SPS/PPS packet appear to   *
             * be the only ones with packet[5] = 0x10, and almost always have packet[5] = 0x10,  *
             * but occasionally have packet[5] = 0x00.                                           */

I am checking this now, and will fix the current http://github.com/FDH2/UxPlay version uxplay-1.52 as needed.

What was the client iOS/macOS device? was it a M1 apple-silecon Mac?

fduncanh commented 2 years ago

@frigaut

what does uxplay -v report as the version number when you had this problem?

fduncanh commented 2 years ago

@frigaut Can you please confirm that the error occurs with the latest version of UxPlay (1.52) from https://github.com/FDH2/UxPlay ?

I can't understand how you got that error.

EDIT: I'm almost certain that your error was introduced in a previous version (a few weeks ago) that was worked on and subsequently fixed.

Please find out whether the current version 1.52 still has this error.

Thanks

antimof / UxPlay

uxplay aborts on video change on ipad #86