Closed soniabhishek closed 7 years ago
Hmm, does it work if you don't include the https://
in host
? That's what I've usually done.
Removing quote might cause trouble when there are paths in the host that do need quoting, so perhaps a better way is using urllib.parse.quote(host, safe='/:')
to exclude quoting colons?
No @antingshen I tried this, but in absence of any protocol, the provided image list URLs are prefixed to current domain like
https://demoserver.in/video/149/d197osy5kcs7h2.cloudfront.net/content/video_pilot/SEQ_6/880_L.jpg
I think your suggested solution is better as we are removing other possibilities
I have fixed changes in PR
Thanks for the fix!
I faced issue while I was adding a video with image_list. Following were my input to the page image_list =
["video_pilot/SEQ_6/630_L.jpg","video_pilot/SEQ_6/640_L.jpg","video_pilot/SEQ_6/650_L.jpg","video_pilot/SEQ_6/660_L.jpg"]
host =https://d197osy5kcs7h2.cloudfront.net/content
After adding this video It was failing because all the generated URLs were wrong with following content
https://demoserver.in/video/149/https%3A//d197osy5kcs7h2.cloudfront.net/content/video_pilot/SEQ_6/880_L.jpg
The quote call was converting https:// => https%3A// This after results in incorrect path.