antirez / dump1090

Dump1090 is a simple Mode S decoder for RTLSDR devices
2.43k stars 1.33k forks source link

Fixes web interface #145

Closed cedarmora closed 4 years ago

cedarmora commented 5 years ago

Fixes #136 web interface error and updates the mapping interface and README to reflect changes in the google maps API.

ghost commented 5 years ago

It dont works

cedarmora commented 5 years ago

PHPoenx, did you follow the instructions I added to the readme?

ereyes01 commented 5 years ago

This worked for me, and the change is pretty simple. It would be nice if the API key could be passed in via a CLI arg, or an environment variable. But it worked for me as-is after following the instructions.

cedarmora commented 5 years ago

For sure, CLI or something would be better but I didn’t have the time to figure it out.

On Sunday, July 7, 2019, Eddy Reyes notifications@github.com wrote:

This worked for me, and the change is pretty simple. It would be nice if the API key could be passed in via a CLI arg, or an environment variable. But it worked for me as-is after following the instructions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/antirez/dump1090/pull/145?email_source=notifications&email_token=AB6UY2YI2EZGC3DRCCWECDDP6KA45A5CNFSM4HWQDQOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZLVZDA#issuecomment-509041804, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6UY2ZKNEKKXJOT7623Y2TP6KA45ANCNFSM4HWQDQOA .

ZL1LAC commented 5 years ago

Any way to switch to OpenStreetMap?

antirez commented 4 years ago

Would using open street map fix the issue? Or it would still require an API key? If OSM does not require any API key I could switch to their APIs.

cedarmora commented 4 years ago

It looks like neither of the OSM tile providers require an API key:

https://switch2osm.org/using-tiles/getting-started-with-leaflet/

https://switch2osm.org/using-tiles/getting-started-with-openlayers/

antirez commented 4 years ago

I tested it a few seconds, I think I really want to switch dump1090 to OSM. I'll do some work in the next days to see if it has all the features we need.

antirez commented 4 years ago

Ported to OSM. Closing.