search

antirez / lamernews

Lamer News -- an HN style social news site written in Ruby/Sinatra/Redis/JQuery
http://lamernews.com
Other
1.35k stars 199 forks source link

Fix urls to links #131

Closed potomak closed 11 years ago

potomak commented 11 years ago

Trying to fix #129 I added a couple of gems: rspec, rake and rack-test.

I used rspec to test urls_to_links, it's also used to test pbkdf2 but the gem wasn't included in the Gemfile.

rake and Rakefile helps running specs, the command is bundle exec rake.

I included also rack-test gem (see http://www.sinatrarb.com/testing.html) even if it's not used at the moment.

fcambus commented 11 years ago

This looks great, have been testing it this afternoon and it works as expected.

+1 for merging!

fcambus commented 11 years ago

By the way, Lamer News doesn't use the pbkdf2 gem but a modified version of it, which is included in the repository.

Actually there is just an include path fix to make in pbkdf2_spec.rb to get the test working.

potomak commented 11 years ago

@fcambus I know, I can include it in the PR if you want. I didn't put it because I thought that it isn't related to the issue.

fcambus commented 11 years ago

No need to, I will add the fix just after merging, no worries :) Thanks again.