Keyboard navigation - Githubissues

antirez / lamernews

Lamer News -- an HN style social news site written in Ruby/Sinatra/Redis/JQuery

http://lamernews.com

Other

1.35k stars 200 forks source link

Keyboard navigation #87

Open seppo0010 opened 13 years ago

seppo0010 commented 13 years ago

In lists navigate with j/k and vote with a/z.

seppo0010 commented 13 years ago

@antirez let me know if you approve the feature and I can work on a pull request.

antirez commented 13 years ago

Hi! I like it, thank you for your contribution :)

p.s. I'm trying to implement the new stuff, especially related to karma, in a way that is easy to enable/disable them, please if you can add something like a KeyboardNavigation constant to app_conf.rb so that it is possible to switch this on/off as needed.

seppo0010 commented 13 years ago

@antirez let me know if there's something you don't like about the pull request to adjust.

antirez commented 13 years ago

Merged! Thank you, great work.

IMHO only two things that can be improved are:

show help on '?'
on comments for some reason the 'selection' box is smaller than the comment itself. Probably related to some HTML bug in the code itself?

seppo0010 commented 13 years ago

@antirez what do you think about adding shortcuts to browse each section? e.g.: g then t opens top, g then l opens latest.

That's widely used in google reader and seems comfortable for me.

fcambus commented 11 years ago

@seppo0010 Merged your fixes, everything works flawlessly now, thanks! :)

Adding shortcuts to browse each section sounds like a great idea, not sure what @antirez thinks about it?