search

antistatique / antistatique.net

Drupal 7 for antistatique website
1 stars 2 forks source link

Responsive main navigation #130

Closed tonifisler closed 9 years ago

zufrieden commented 9 years ago

@guillaumeberry please review

tonifisler commented 9 years ago

I think we need to add a background or something behind the × Close button. It gets unreadable on certain cases.

guillaumeberry-zz commented 9 years ago

What do you think guys? @zufrieden @tonifisler responsive-nav-mobile responsive-nav-tablet

tonifisler commented 9 years ago

I think the arrow is not quite the best solution... Maybe a × would be better?

zufrieden commented 9 years ago

I'm ok with the arrow. But it would be better to have this close button at the center.

On Wed, May 27, 2015 at 5:24 PM, tonifisler notifications@github.com wrote:

I think the arrow is not quite the best solution... Maybe a × would be better?

— Reply to this email directly or view it on GitHub https://github.com/antistatique/antistatique.net/issues/130#issuecomment-105956326 .

Marc Friederich marc@antistatique.net

Antistatique http://antistatique.net/ rue de Sébeillon 9b 1004 Lausanne +41 21 623 63 03 www.antistatique.net

gido commented 9 years ago

Testé, c'est pas encore ça

guillaumeberry-zz commented 9 years ago

@gido I know… On it!

guillaumeberry-zz commented 9 years ago

responsive-nav poke @zufrieden @tonifisler Make a wish/mix/choice/guess/review/feedback/decision :hamster:

& on invision : http://invis.io/S434K93QE

tonifisler commented 9 years ago

I would say n°2 with a full-width button. Seems to be the best solution.

We need to have a clear "Contact us" button that is separated from the rest of the menu (unlike n°8) because it is the same URL as "With you" (...me no like it...) and because we already have the paper-plane when the menu is collapsed. The user who doesn't understand this paper-plane should be able to find how to contact us nevertheless.

Full-width for the "Contact us" button seems a better idea since the logo is franc bord.

And I'd like the french - english better as fr-en and the "Close" button without its label. :)

ClientPasChiant

guillaumeberry-zz commented 9 years ago

Updated, dear client!

zufrieden commented 9 years ago

Ok for version 2 with a small change check this new_menu

guillaumeberry-zz commented 9 years ago

Are we good with this? @tonifisler @zufrieden final-final

zufrieden commented 9 years ago

Yes. Now we have to design transitions On Jun 4, 2015 11:43 AM, "Guillaume Berry" notifications@github.com wrote:

Are we good with this? @tonifisler https://github.com/tonifisler @zufrieden https://github.com/zufrieden [image: final-final] https://cloud.githubusercontent.com/assets/1800253/7981386/e2a4baf0-0aae-11e5-887e-72ec1667e9c2.png

— Reply to this email directly or view it on GitHub https://github.com/antistatique/antistatique.net/issues/130#issuecomment-108809719 .

tonifisler commented 9 years ago

So is there a box-shadow on the image? Or is it on the dropdown too, to be sure the "× Menu" is readable on all backgrounds?

guillaumeberry-zz commented 9 years ago

@tonifisler You can probably use the same gradient that we have on cover images (inverted, height:48px). This gradient is here so xMenu is readable no matter the background (so always in white).

Source files are here: /Projects/001_antistatique_communication/Communication/5_site_web/maquettes-new-site-2015/Navigation-responsive.ai

tonifisler commented 9 years ago

Ok so I had to write the lang-switcher as it is on desktop. We should re-write the preprocessor to display the whole language string, but I didn't want to waste time on it more than I already did...

guillaumeberry-zz commented 9 years ago

Apart from this, all good for V1.0!

tonifisler commented 9 years ago

One tiny pixel left at the top of the menu (we see the image below)

Was already done in commit just before your comment :wink:

guillaumeberry-zz commented 9 years ago

:heart_eyes: